Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove calls with deprecated dir argument #312

Merged
merged 2 commits into from Apr 14, 2023
Merged

Conversation

jcapriot
Copy link
Member

Update internal calls to the make_boundary_bool function, changing dir to bdir

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #312 (c758b05) into main (53002e1) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
- Coverage   85.24%   85.23%   -0.02%     
==========================================
  Files          38       38              
  Lines       11301    11301              
==========================================
- Hits         9634     9632       -2     
- Misses       1667     1669       +2     
Impacted Files Coverage Δ
discretize/base/base_tensor_mesh.py 88.18% <100.00%> (ø)
discretize/curvilinear_mesh.py 96.68% <100.00%> (ø)
discretize/operators/differential_operators.py 80.96% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jcapriot jcapriot merged commit bffe98a into simpeg:main Apr 14, 2023
13 of 14 checks passed
@jcapriot jcapriot deleted the bdir_calls branch April 14, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant