Extend BaseScr to that Pole and Dipole DC are simply minor extensions… #1007
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1007 +/- ##
==========================================
- Coverage 79.14% 79.13% -0.02%
==========================================
Files 158 158
Lines 20934 20954 +20
==========================================
+ Hits 16569 16581 +12
- Misses 4365 4373 +8
Continue to review full report at Codecov.
|
|
@jcapriot, requesting review. Cheers! |
|
@jcapriot I've checked and the current test failure is the same as HEAD on master and so is unrelated. Is there any issues against getting this merged? |
|
Hi @ngodber, thanks for your contribution! |
There was a problem hiding this comment.
Hi @ngodber, thanks for your contribution!
Overall, your changes looking good to me. If you can explain a bit more about the Mulpole class that will be helpful. My guess is the case when there are more than two electrodes, but not exactly sure yet.
|
Hi Seogi,
My application is actually in an engineering context which is why it
doesn't exactly fit in the standard RES survey format. The purpose is that
I have a source that is in effect a series of point sources that fill a
volume of area but do not have a strike extent (so I can just embed the
electrodes in a conductive material and call it a day). The scenario I am
attempting to model is a vertical array of electrodes in parallel.
Sometimes these arrays can have significant vertical extent (> 20m) and we
are not sufficiently distant that it is adequate to treat them as a point
source.
Cheers,
Neil
…On Tue, 10 Aug 2021 at 16:07, Seogi Kang ***@***.***> wrote:
Hi @ngodber <https://github.com/ngodber>, thanks for your contribution!
It seems the major change that you have made was generalizing eval
function for Pole and Dipole sources in BaseSrc.
That part looks fine to me. However, I was not sure what was Mutipole
source is for?
Can you explain what your intention was for?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1007 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC2JLXUUE7IRMD4NVWRASYLT4C6ZNANCNFSM45FWY4MQ>
.
|
… of it. Introduce explicit multipole source.
…d type check for curvilinear in 2d DC simulation class and use edge_lengths instead.
…to calcualte closest points.
ngodber
force-pushed
the
dc_general_source
branch
2 times, most recently
from
2a1a8ea
to
9f2d275
Compare
ngodber
force-pushed
the
dc_general_source
branch
from
9f2d275
to
1968006
Compare
|
@sgkang codecov is somehow bugged now, I added tests to improve coverage and somehow its gone way down!? |
…reated via other implementations (two sources and one sink). Simulates orthogonally orientated array.
|
@sgkang Updated test to make to truly multipole (rather than a 'multipole' that was in fact a dipole). |
|
@lheagy this is the PR I was referring too in the meeting. |
Implement Multipole source and refactor BaseSrc for em.Static so that all source types are simply interfaces. PR also includes a number of minor bug fixes.