include the number of turns in the source initialization #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaut-kobold
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1086 +/- ##
==========================================
+ Coverage 79.04% 79.06% +0.01%
==========================================
Files 137 137
Lines 20206 20224 +18
==========================================
+ Hits 15972 15990 +18
Misses 4234 4234
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jcapriot
reviewed
May 30, 2022
|
@jcapriot any recommendation to help this PR get merged? I tried adding test earlier but did not help (and I am in the field at the moment) |
lheagy
approved these changes
Aug 9, 2022
Co-authored-by: Lindsey Heagy <lindseyheagy@gmail.com>
Co-authored-by: Lindsey Heagy <lindseyheagy@gmail.com>
Co-authored-by: Lindsey Heagy <lindseyheagy@gmail.com>
Co-authored-by: Lindsey Heagy <lindseyheagy@gmail.com>
Co-authored-by: Lindsey Heagy <lindseyheagy@gmail.com>
Co-authored-by: Lindsey Heagy <lindseyheagy@gmail.com>
Co-authored-by: Lindsey Heagy <lindseyheagy@gmail.com>
# Conflicts: # SimPEG/electromagnetics/time_domain/sources.py
…turns # Conflicts: # SimPEG/electromagnetics/time_domain/sources.py
# Conflicts: # SimPEG/electromagnetics/frequency_domain/sources.py # SimPEG/electromagnetics/time_domain/sources.py # tests/em/fdem/forward/test_FDEM_sources.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
geoanaimplementation to make this change backward compatible with oldergeoanaversions