Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 2D_CC boundary conditions #1128

Merged
merged 2 commits into from Nov 8, 2022
Merged

Conversation

jcapriot
Copy link
Member

@jcapriot jcapriot commented Nov 7, 2022

Takes the boundary condition into account when calculating the e and j fields for 2D cell_centered dc resistivity.
address #1033.

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #1128 (570029f) into main (28f06ef) will decrease coverage by 9.38%.
The diff coverage is 100.00%.

❗ Current head 570029f differs from pull request most recent head f33d960. Consider uploading reports for the commit f33d960 to get more accurate results

@@            Coverage Diff             @@
##             main    #1128      +/-   ##
==========================================
- Coverage   79.59%   70.20%   -9.39%     
==========================================
  Files         137      137              
  Lines       20943    20955      +12     
==========================================
- Hits        16670    14712    -1958     
- Misses       4273     6243    +1970     
Impacted Files Coverage Δ
...G/electromagnetics/static/resistivity/fields_2d.py 79.79% <100.00%> (+2.78%) ⬆️
SimPEG/dask/simulation.py 0.00% <0.00%> (-100.00%) ⬇️
...mPEG/dask/potential_fields/magnetics/simulation.py 0.00% <0.00%> (-94.45%) ⬇️
SimPEG/dask/potential_fields/gravity/simulation.py 0.00% <0.00%> (-92.86%) ⬇️
SimPEG/dask/potential_fields/base.py 0.00% <0.00%> (-90.91%) ⬇️
SimPEG/regularization/jtv.py 16.66% <0.00%> (-83.34%) ⬇️
SimPEG/regularization/cross_gradient.py 16.88% <0.00%> (-81.82%) ⬇️
.../electromagnetics/static/resistivity/simulation.py 0.00% <0.00%> (-78.27%) ⬇️
SimPEG/utils/io_utils/io_utils_pf.py 23.86% <0.00%> (-73.30%) ⬇️
SimPEG/dask/__init__.py 0.00% <0.00%> (-70.00%) ⬇️
... and 38 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jcapriot jcapriot merged commit 8c673b3 into simpeg:main Nov 8, 2022
@jcapriot jcapriot deleted the 2D_DC_fields branch November 8, 2022 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant