Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should really be dependent on Cython, if we're going to call
cythonize
directly in the build script, and if Cython is needed for good performance. Or, if not, we would need to make the import ofcythonize
conditional, and then skip building the extension if Cython isn't installed. Alternatively, don't build the .pyx file, and check in a compiled .c file; then make the following changes to setup.py:from Cython.Build import cythonize
on Line 10 withfrom setuptools.extension import Extension
ext_modules = cythonize('SimPEG/Utils/interputils_cython.pyx')
on Line 53 withext_modules = [Extension('interputils_cython', sources=['SimPEG/Utils/interputils_cython.c'])]