Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix F522, F523, F524 flake errors: format calls #1245

Merged
merged 3 commits into from Jun 21, 2023

Conversation

santisoler
Copy link
Member

@santisoler santisoler commented Jun 20, 2023

Summary

Remove them from the ignored flake warning list in .flake8. Solve issues regarding wrong calls to format(). Use f-strings instead.

PR Checklist

  • If this is a work in progress PR, set as a Draft PR
  • Linted my code according to the style guides.
  • Added tests to verify changes to the code.
  • Added necessary documentation to any new functions/classes following the
    expect style.
  • Added relevant method tags (i.e. GRAV, EM, etc.)
  • Marked as ready for review (ff this is was a draft PR), and converted
    to a Pull Request
  • Tagged @simpeg/simpeg-developers when ready for review.

Reference issue

What does this implement/fix?

Additional information

Would be nice to merge this after #1238. The F522, F523 and F524 errors should be removed
from the .flake8 file.

TODO

Remove them from the ignored flake warning list in the Makefile. Solve
issues regarding wrong calls to `format()`. Use f-strings instead.
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #1245 (f63fb87) into main (b8dcec5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1245   +/-   ##
=======================================
  Coverage   82.31%   82.31%           
=======================================
  Files         164      164           
  Lines       24958    24958           
=======================================
  Hits        20544    20544           
  Misses       4414     4414           
Impacted Files Coverage Δ
SimPEG/electromagnetics/static/resistivity/IODC.py 62.80% <ø> (ø)

@jcapriot jcapriot merged commit f037adf into simpeg:main Jun 21, 2023
14 of 16 checks passed
@santisoler santisoler deleted the flake-format-args branch June 21, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants