Remove the debug argument from InversionDirective #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the `debug` argument and property from `InversionDirective`, add new test to check if it raises an error when passing it as argument. Update directive class using the `debug` property.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1370 +/- ##
==========================================
- Coverage 82.30% 82.08% -0.23%
==========================================
Files 165 165
Lines 25233 25232 -1
==========================================
- Hits 20769 20711 -58
- Misses 4464 4521 +57 ☔ View full report in Codecov by Sentry. |
|
The random number generator in the tests is rather annoying, I feel like we really need to get support for numpy's generator objects in to all of the tests soon, just so we don't keep having this problem... |
|
It is annoying: #1289 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
debugargument and property fromInversionDirective, add new test to check if it raises an error when passing it as argument. Update directive class using thedebugproperty.PR Checklist
expect style.
to a Pull Request
@simpeg/simpeg-developerswhen ready for review.Reference issue
Part of the solution for #1302
What does this implement/fix?
Additional information
Most of these changes were cherry-picked from #1306