Replace use of refine_tree_xyz in DCIP tutorials
#1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the use of `refine_tree_xyz` in DC-IP tutorials for their corresponding counterpart methods of discretize meshes: `refine_bounding_box`, `refine_points` and `refine_surface`.
|
With these changes, I could run the tutorials locally without errors. @dccowan could you take a look at this? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1381 +/- ##
=======================================
Coverage 82.54% 82.54%
=======================================
Files 167 167
Lines 25700 25700
=======================================
Hits 21214 21214
Misses 4486 4486 ☔ View full report in Codecov by Sentry. |
thibaut-kobold
added a commit
to KoBoldMetals/simpeg
that referenced
this pull request
May 8, 2024
…e_simpeg_021 * commit 'fe444e2d714ab1a3f1541575a9f8c4ad1e74894b': (73 commits) Fix distance calculation in `convert_survey_3d_to_2d_lines` (simpeg#1390) Rename spontaneous potential to self potential (simpeg#1422) Lowercase simpeg for generating coverage on Azure (simpeg#1443) Replace SimPEG for simpeg across docstrings (simpeg#1438) Update copyright year in __init__.py (simpeg#1436) Move to a PEP8 compliant package name. (simpeg#1430) Fix rst syntax in release notes for v0.21.0 (simpeg#1434) Replace use of `refine_tree_xyz` in DCIP tutorials (simpeg#1381) Add new Issue template for making a release (simpeg#1410) Safely run reviewdog on `pull_request_target` events (simpeg#1427) Use reviewdog to annotate PR's with black and flake8 errors. (simpeg#1424) Remove the parameters argument from docstring (simpeg#1417) Add release notes for v0.21.1 (simpeg#1416) Fix hard dask dependency (simpeg#1415) Publish documentation on azure (simpeg#1412) Add release notes for SimPEG v0.21 (simpeg#1409) Bump Black version to 24.3.0 (simpeg#1403) Remove link to "twitter" (simpeg#1406) Add Ying and Williams to AUTHORS.rst (simpeg#1405) Dask MetaSim (simpeg#1199) ... # Conflicts: # simpeg/electromagnetics/base_1d_stitched.py # simpeg/electromagnetics/frequency_domain/simulation_1d_stitched.py # simpeg/electromagnetics/time_domain/receivers.py # simpeg/electromagnetics/time_domain/simulation_1d_stitched.py # simpeg/electromagnetics/utils/em1d_utils.py # simpeg/potential_fields/magnetics/_numba_functions.py # simpeg/regularization/laterally_constrained.py # simpeg/regularization/regularization_mesh_lateral.py # simpeg/regularization/rotated.py # simpeg/utils/__init__.py # simpeg/utils/model_utils.py # tests/base/regularizations/test_full_gradient.py # tests/base/regularizations/test_regularization.py # tests/base/test_mass_matrices.py # tests/base/test_model_utils.py # tests/base/test_utils.py # tests/em/fdem/inverse/adjoint/test_FDEM_adjointEB.py # tests/em/fdem/inverse/derivs/test_FDEM_derivs.py # tests/pf/test_forward_Mag_Linear.py
thibaut-kobold
added a commit
to KoBoldMetals/simpeg
that referenced
this pull request
May 8, 2024
…al_update_21_release * commit '07aeb65de865cd9df55e2d51ca840ea9d60f2234': (67 commits) Fix rst syntax in release notes for v0.21.0 (simpeg#1434) Replace use of `refine_tree_xyz` in DCIP tutorials (simpeg#1381) Add new Issue template for making a release (simpeg#1410) Safely run reviewdog on `pull_request_target` events (simpeg#1427) Use reviewdog to annotate PR's with black and flake8 errors. (simpeg#1424) Remove the parameters argument from docstring (simpeg#1417) Add release notes for v0.21.1 (simpeg#1416) Fix hard dask dependency (simpeg#1415) Publish documentation on azure (simpeg#1412) Add release notes for SimPEG v0.21 (simpeg#1409) Bump Black version to 24.3.0 (simpeg#1403) Remove link to "twitter" (simpeg#1406) Add Ying and Williams to AUTHORS.rst (simpeg#1405) Dask MetaSim (simpeg#1199) Update year in LICENSE (simpeg#1404) Update AUTHORS.rst (simpeg#1259) Minor adjustments to Sphinx configuration (simpeg#1398) Enforce regularization `weights` as dictionaries (simpeg#1344) Improve documentation for base simulation classes (simpeg#1295) Add link to User Tutorials to navbar in docs (simpeg#1401) ... # Conflicts: # SimPEG/electromagnetics/time_domain/receivers.py # SimPEG/utils/__init__.py # SimPEG/utils/model_utils.py # tests/base/regularizations/test_full_gradient.py # tests/base/regularizations/test_regularization.py # tests/base/test_model_utils.py # tests/base/test_utils.py # tests/pf/test_forward_Mag_Linear.py
thibaut-kobold
added a commit
to thibaut-kobold/simpeg
that referenced
this pull request
May 9, 2024
…ting_strategy * commit 'fe444e2d714ab1a3f1541575a9f8c4ad1e74894b': (86 commits) Fix distance calculation in `convert_survey_3d_to_2d_lines` (simpeg#1390) Rename spontaneous potential to self potential (simpeg#1422) Lowercase simpeg for generating coverage on Azure (simpeg#1443) Replace SimPEG for simpeg across docstrings (simpeg#1438) Update copyright year in __init__.py (simpeg#1436) Move to a PEP8 compliant package name. (simpeg#1430) Fix rst syntax in release notes for v0.21.0 (simpeg#1434) Replace use of `refine_tree_xyz` in DCIP tutorials (simpeg#1381) Add new Issue template for making a release (simpeg#1410) Safely run reviewdog on `pull_request_target` events (simpeg#1427) Use reviewdog to annotate PR's with black and flake8 errors. (simpeg#1424) Remove the parameters argument from docstring (simpeg#1417) Add release notes for v0.21.1 (simpeg#1416) Fix hard dask dependency (simpeg#1415) Publish documentation on azure (simpeg#1412) Add release notes for SimPEG v0.21 (simpeg#1409) Bump Black version to 24.3.0 (simpeg#1403) Remove link to "twitter" (simpeg#1406) Add Ying and Williams to AUTHORS.rst (simpeg#1405) Dask MetaSim (simpeg#1199) ... # Conflicts: # simpeg/utils/__init__.py # simpeg/utils/model_utils.py # tests/base/test_model_utils.py
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace the use of
refine_tree_xyzin DC-IP tutorials for their corresponding counterpart methods of discretize meshes:refine_bounding_box,refine_pointsandrefine_surface.PR Checklist
expect style.
to a Pull Request
@simpeg/simpeg-developerswhen ready for review.Reference issue
Fixes #1379
What does this implement/fix?
Additional information