Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Numpy rng in NSEM tests #1450

Merged
merged 4 commits into from
Jun 24, 2024
Merged

Use Numpy rng in NSEM tests #1450

merged 4 commits into from
Jun 24, 2024

Conversation

santisoler
Copy link
Member

@santisoler santisoler commented May 6, 2024

Summary

Replace the usage of the deprecated functions in numpy.random module for the Numpy's random number generator class and its methods, in most of the NSEM tests.

PR Checklist

  • If this is a work in progress PR, set as a Draft PR
  • Linted my code according to the style guides.
  • Added tests to verify changes to the code.
  • Added necessary documentation to any new functions/classes following the
    expect style.
  • Marked as ready for review (if this is was a draft PR), and converted
    to a Pull Request
  • Tagged @simpeg/simpeg-developers when ready for review.

Reference issue

Part of the solution to #1289

What does this implement/fix?

Additional information

Replace the usage of the deprecated functions in `numpy.random` module
for the Numpy's random number generator class and its methods, in most
of the NSEM tests.
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.23%. Comparing base (fb10cda) to head (afbac95).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1450      +/-   ##
==========================================
+ Coverage   85.77%   86.23%   +0.45%     
==========================================
  Files         390      396       +6     
  Lines       49669    50327     +658     
  Branches     5290     5308      +18     
==========================================
+ Hits        42606    43401     +795     
+ Misses       5626     5474     -152     
- Partials     1437     1452      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

These extra lines should be removed after adding the `seed` argument in
discretize `check_derivative` function.
@santisoler santisoler merged commit 7f86584 into main Jun 24, 2024
19 checks passed
@santisoler santisoler deleted the rng-nsem-tests branch June 24, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant