-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dask races #1469
Open
jcapriot
wants to merge
26
commits into
simpeg:main
Choose a base branch
from
jcapriot:dask_races
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dask races #1469
+152
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1469 +/- ##
==========================================
- Coverage 53.17% 46.16% -7.01%
==========================================
Files 171 168 -3
Lines 26023 25758 -265
==========================================
- Hits 13838 11892 -1946
- Misses 12185 13866 +1681 ☔ View full report in Codecov by Sentry. |
(now that it's respecting the python version)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates for
dask>2024.2.1
PR Checklist
expect style.
to a Pull Request
@simpeg/simpeg-developers
when ready for review.What does this implement/fix?
A few things:
dask recently updated how things items are hashed to create a more deterministic hash for items. For objects it will change depending on the state of the objects.
Simulation
objects are mutable things, thus their hash would change overtime for the same object. For theDaskMetaSimulation
, we want a single simulation's hash (also a single map's hash) to be constant in time, so this PR adds uuid properties to each of those base classes that are then registered to be used by dask to hash the objects.This deterministic hashing lead to a race condition in the error testing. When objects are scattered, dereferenced, then scattered again. The garbage collector would destroy the scattered objects dereferenced from the first call
after
the second scatter, thus creating a case where we are trying to access a Canceled Future.This is also now a bit more rigorous about only using a single worker for each simulation operation when the simulations inadvertently live on multiple workers, by selecting the worker that had fewer simulations assigned to it.
Additional information
See dask/distributed#8576 for more information about the race condition.
This also implements one of the updates in #1444 regarding the testing environment script so that we are sure we are creating the correct environment.