Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dc2d: Pseudosection and add warning in examples for the observation file format #969

Merged
merged 4 commits into from May 19, 2021

Conversation

thast
Copy link
Member

@thast thast commented Feb 4, 2021

  • Pseudosection failed to plot for Wenner array
  • In the example, the observations file to build the survey is assumed to be sorted by sources, but it was not mention anywhere. I added a warning regarding that.

Thank you ericjohnson on discourse for pointing us those issues.

TODO: rename from_ambn_locations_to_survey to from_abmn_locations_to_survey

@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #969 (285b7e4) into main (055ca54) will increase coverage by 0.00%.
The diff coverage is 55.55%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #969   +/-   ##
=======================================
  Coverage   78.79%   78.79%           
=======================================
  Files         173      173           
  Lines       20720    20723    +3     
=======================================
+ Hits        16326    16329    +3     
  Misses       4394     4394           
Impacted Files Coverage Δ
...mPEG/electromagnetics/static/utils/static_utils.py 71.74% <0.00%> (ø)
SimPEG/electromagnetics/static/resistivity/IODC.py 48.38% <71.42%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 055ca54...285b7e4. Read the comment docs.

@jcapriot jcapriot merged commit 489477f into main May 19, 2021
@jcapriot jcapriot deleted the fix_dc2d branch May 19, 2021 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants