Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

property 1 is incorrectly displayed #35

Closed
nathanfranklin opened this issue Jan 14, 2016 · 3 comments
Closed

property 1 is incorrectly displayed #35

nathanfranklin opened this issue Jan 14, 2016 · 3 comments
Assignees
Labels
Milestone

Comments

@nathanfranklin
Copy link
Member

error_property1

Version 6.5, commit b29c73a

Input file:

10
#XZYfile
X0 1.9265350878690097e+00 1.2235141067428751e+01 -9.0000000000000000e+00 1.0 1.0
X0 1.9907529241313100e+01 1.2235141067428751e+01 0.0000000000000000e+00 2.0  2.0
X0 2.5044956142297124e+01 7.7859988610910245e+00 0.0000000000000000e+00 2.0 2.0
X0 2.2476242691805112e+01 1.4459712170597616e+01 0.0000000000000000e+00 2.0 2.0
X0 1.0274853801968051e+01 1.3347426619013184e+01 0.0000000000000000e+00 2.0 2.0
X0 1.2843567252460064e+01 1.7796568825350910e+01 0.0000000000000000e+00 2.0 2.0
X0 1.6696637428198084e+01 1.5571997722182049e+01 0.0000000000000000e+00 2.0 2.0
X0 2.4402777779674121e+01 2.0021139928519776e+01 0.0000000000000000e+00 2.0 2.0
X0 1.2843567252460064e+01 6.6737133095065921e+00 0.0000000000000000e+00 2.0 2.0
X0 7.7061403514760389e+00 1.1122855515844320e+01 3.0000000000000000e+01 5.0 5.0

Property 2 (which has the exact same values) is properly displayed, but property 1 is displayed incorrectly.

@nathanfranklin
Copy link
Member Author

@simphony/iit @joanadler @simphony/fraunhofer-iwm

@ahashibon
Copy link
Contributor

from the figure it looks like the color scale is zero, so searching for the color scale range leads to glCanvasFrame.cpp which shows that indeed, the minimum value for the p1 (property 1) is not calculated for some reason (all other properties are correctly calculated).
so adding this:
if ((_ad).particles[i].prop1 < p1min)
p1min = (_ad).particles[i].prop1;
solves this problem.
I will upload a branch for testing.

@ahashibon ahashibon self-assigned this Jan 18, 2016
ahashibon added a commit that referenced this issue Jan 18, 2016
nathanfranklin added a commit that referenced this issue Jan 19, 2016
@nathanfranklin
Copy link
Member Author

closed by #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants