Merge pull request #405 from simphony/noqa-for-cuba-enum-long-lines

Added noqa to the cuba enum parser when long lines are present

scripts/cuba_enum_generator.py

@@ -20,14 +20,18 @@ def generate(self, ontology, output):
             '@unique\n',
             'class CUBA(Enum):\n'
             ]
-        template = '    {cuba_name} = "{cuba_name}"\n'
+        template = '    {cuba_name} = "{cuba_name}"'
 
         all_keys = set(d.name for d in ontology.data_types)
         all_keys.update([d.name for d, _ in traverse(ontology.root_cuds_item)])
 
         for keyword in sorted(list(all_keys)):
-            lines.append(
-                template.format(
-                    cuba_name=without_cuba_prefix(keyword)))
+            line = template.format(cuba_name=without_cuba_prefix(keyword))
+
+            # yapf does not break such lines, so we have to get creative.
+            if len(line) >= 79:
+                line += "  # noqa"
+
+            lines.append(line+'\n')
 
         output.writelines(lines)

scripts/tests/test_cuba_enum_generator.py

@@ -1,6 +1,7 @@
 import unittest
 from six import StringIO
 
+from simphony_metaparser.nodes import CUDSItem
 from scripts.cuba_enum_generator import CUBAEnumGenerator
 from scripts.tests import fixtures
 
@@ -21,3 +22,20 @@ def test_basic_parsing(self):
             self.assertIn(
                 '{keyword} = "{keyword}"'.format(
                     keyword=keyword), text)
+
+    def test_long_line(self):
+        generator = CUBAEnumGenerator()
+        output = StringIO()
+        self.ontology.root_cuds_item.children.append(
+            CUDSItem(
+                name="CUBA.REALLY_LONG_NAME_THAT_GOES_BEYOND_THE_79_CHARACTER_LIMIT",  # noqa
+                parent=self.ontology.root_cuds_item
+                )
+            )
+
+        generator.generate(self.ontology, output)
+
+        text = output.getvalue()
+        self.assertIn(
+            '"REALLY_LONG_NAME_THAT_GOES_BEYOND_THE_79_CHARACTER_LIMIT"  # noqa',  # noqa
+            text)