Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve import and export functions #818

Merged
merged 22 commits into from
Sep 26, 2022
Merged

Improve import and export functions #818

merged 22 commits into from
Sep 26, 2022

Conversation

kysrpex
Copy link
Contributor

@kysrpex kysrpex commented Sep 14, 2022

  • Properly documented options all_triples (all statements where an ontology individual is the subject) and all_statements (all RDF statements) to enable importing and exporting RDF statements that are not supported by SimPhoNy.

  • Add tests for all_triples and all_statements. Fix test_api_importexport_data.json (did not match the turtle and xml versions).

  • Rename path_or_filelike argument of import_file to file.

  • Treat IRIs with type owl:NamedIndividual as individuals of class owl:Thing.

  • Warn when ignoring RDF statements where an individual that is being added is the subject.

  • Emit warnings on add when uninterpretable statements are included with the entities to be added. Remove the warning for references to individuals that are not being added simultaneously.

  • Raise exception when importing references to unknown individuals, terminological knowledge, or individuals of an unknown class.

  • Do not overwrite individuals when importing.

* Properly documented options `all_triples` (all statements where an ontology individual is the subject) and `all_statements` (all RDF statements) to enable importing and exporting RDF statements that are not supported by SimPhoNy.

* Add tests for `all_triples` and `all_statements`. Fix `test_api_importexport_data.json` (did not match the turtle and xml versions).

* Rename `path_or_filelike` argument of `import_file` to `file`.

* Treat IRIs with type `owl:NamedIndividual` as individuals of class `owl:Thing`.
@kysrpex kysrpex added 🐛 bug API details ℹ️ best practices ⚡ breaking change Solution introduces incompatible API changes, MAJOR version number update. See https://semver.org. labels Sep 14, 2022
@kysrpex kysrpex self-assigned this Sep 14, 2022
kysrpex and others added 15 commits September 15, 2022 11:27
…ith the entities to be added. Remove the warning for references to individuals that are not being added simultaneously.
* Raise exception when importing references to unknown individuals, terminological knowledge, or individuals of an unknown class.

* Raise exception when exporting references to unknown individuals, terminological knowledge, or individuals of an unknown class.
@kysrpex kysrpex marked this pull request as ready for review September 26, 2022 13:26
@kysrpex kysrpex merged commit b0a7ba2 into release/4/dev Sep 26, 2022
@kysrpex kysrpex deleted the import_export branch September 26, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API details 🐛 bug ℹ️ best practices ⚡ breaking change Solution introduces incompatible API changes, MAJOR version number update. See https://semver.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant