Remove top-level Ember imports from generated authenticators #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Ember` is not used in any of the generated authenticators and only makes jshint sad.
bakerac4
pushed a commit
to bakerac4/ember-simple-auth
that referenced
this pull request
Sep 8, 2016
…ter#1055) `Ember` is not used in any of the generated authenticators and only makes jshint sad.
| @@ -15,25 +15,25 @@ module.exports = { | |||
|
|
|||
| if (baseClass === 'torii') { | |||
| return { | |||
| imports: 'import Ember from \'ember\';' + EOL + 'import Torii from \'ember-simple-auth/authenticators/torii\';', | |||
| imports: 'import Torii from \'ember-simple-auth/authenticators/torii\';', | |||
| baseClass: 'Torii', | |||
| body: EOL + ' torii: Ember.inject.service(\'torii\')' | |||
There was a problem hiding this comment.
I've not actually tested this, but just happened to notice that this authenticator does appear to use the imported Ember module.
There was a problem hiding this comment.
I removed that line because I received a jslint error about the unused import. Not sure what the difference is between your setup and mine is, then.
There was a problem hiding this comment.
That line is actually necessary as the authenticator cannot access torii otherwise but the import should be removed. PR would be awesome!
There was a problem hiding this comment.
@balinterdi I didn't actually see an error, it was just an observation I made when looking through the contents of recent commits. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emberis not used in any of the generated authenticators and only makes jshint sad.