Remove setOwner() calls #1164
Merged
Remove setOwner() calls #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... to prevent setOwner() calls on Ember versions that don't support it
marcoow
approved these changes
Jan 4, 2017
|
@Turbo87 don't really understand why the tests would fail here… |
|
because passing in got a workaround prepared already. will push soon. |
|
@marcoow updated the PR with the new solution |
marcoow
approved these changes
Jan 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setOwner()is not polyfilled by ember-getowner-polyfill and fails on older Ember versions. UsingsetOwner()in the tests was introduced by #1124, which should have failed CI, but apparently went through for some unknown reason (possibly a caching issue or some transitive dependency constraint on the polyfill?).This is needed until ember-polyfills/ember-getowner-polyfill#14 lands.