fix deprecated import of getOwner #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoow
requested changes
Dec 9, 2016
| @@ -78,7 +78,6 @@ | |||
| "ember-cli-import-polyfill": "^0.2.0", | |||
| "ember-cli-is-package-missing": "^1.0.0", | |||
| "ember-cookies": "^0.0.10", | |||
| "ember-getowner-polyfill": "^1.0.1", | |||
There was a problem hiding this comment.
This is still needed but in a later version
There was a problem hiding this comment.
I removed that because of ember-getowner-polyfill is not required for Ember 2.3.0 and later, please remove from your package.json`` at build time, but I think if you want to keep ember-simple-auth compatible with ember 1.12+ this dependency is required, right ?
There was a problem hiding this comment.
Yes, we'll want to maintain the current compatibility unless not possible anymore.
|
|
||
| describe('InternalSession', () => { | ||
| describe('InternalSession', function() { |
There was a problem hiding this comment.
using arrow functions should be fine here unless you want to use this
marcoow
approved these changes
Dec 9, 2016
|
🎉 |
This was referenced Jan 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix the second deprecation in #1122
Not sure if using setOwner this way in the tests is the right way though.
At least for the SessionService, maybe using the setupTest thing from is the way to go, but I guess it implies a bigger refactor
I just realize that it would be breaking change...