Engine Support #1764
Merged
Engine Support #1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoow
force-pushed
the
engine
branch
5 times, most recently
from
7bba3f0
to
a5d7c5e
Compare
marcoow
force-pushed
the
engine
branch
3 times, most recently
from
e513cc4
to
0dd591d
Compare
sdebarros
reviewed
Apr 3, 2020
sdebarros
reviewed
Apr 3, 2020
marcoow
force-pushed
the
engine
branch
2 times, most recently
from
96d7350
to
25c2386
Compare
sdebarros
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an engine to the dummy app so we can validate/test we support engines correctly.
TODO
ideally we can automatically– this actually makes no sense as the authentication route could be within the enginetransitionToExternalinstead oftransitionToin theAuthenticatedRouteMixinif we detect we're running in an engine (and the login route is not in the enging)disable engines tests in ember versions < 2.12– this is no longer necessary as we dropped support for Ember versions < 3.0