Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SameSite cookie attribute support #1848

Merged
merged 4 commits into from
Nov 7, 2019
Merged

Add SameSite cookie attribute support #1848

merged 4 commits into from
Nov 7, 2019

Conversation

Exelord
Copy link
Contributor

@Exelord Exelord commented May 27, 2019

Adds SameSite support: mainmatter/ember-cookies#269

@marcoow
Copy link
Member

marcoow commented Nov 6, 2019

SameSite support was released as part of ember-cookies 0.5.1: https://github.com/simplabs/ember-cookies/releases/tag/0.5.1. Can you update the ember-cookies dependency as part of this PR and add some tests?

@Exelord
Copy link
Contributor Author

Exelord commented Nov 6, 2019

@marcoow Done! :)

marcoow
marcoow reviewed Nov 7, 2019
View reviewed changes
Copy link
Member

@marcoow marcoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, only one small thing

package.json Outdated Show resolved Hide resolved
@marcoow marcoow merged commit 64774a3 into mainmatter:master Nov 7, 2019
@Exelord Exelord deleted the patch-1 branch November 7, 2019 13:55
@jfdnc
Copy link

jfdnc commented Dec 2, 2019

@marcoow Do we know when this change will make it into a release?

@jfdnc
Copy link

jfdnc commented Dec 22, 2019

Looks like it made it into 2.1.1!
kthnx

@makepanic makepanic mentioned this pull request Aug 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoow marcoow marcoow approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Exelord @marcoow @jfdnc