Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix computed import deprecation #2296

Merged
merged 1 commit into from
May 7, 2021
Merged

Conversation

knownasilya
Copy link
Contributor

Resolving this deprecation: DEPRECATION: Using computed.oneWay has been deprecated. Instead, import the value directly from @ember/object/computed

Resolving this deprecation: `DEPRECATION: Using `computed.oneWay` has been deprecated. Instead, import the value directly from @ember/object/computed`
Copy link
Member

@marcoow marcoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙌

I rebased on master to fix CI

@marcoow marcoow merged commit d11bc27 into mainmatter:master May 7, 2021
@knownasilya
Copy link
Contributor Author

Sweet!

@knownasilya knownasilya deleted the patch-2 branch May 7, 2021 15:07
@josemarluedke
Copy link
Contributor

@marcoow Can we get a release out with this fix? Thanks.

@jordpo
Copy link

jordpo commented Aug 25, 2021

👋 Can we get a release with the latest changes? Thank you!

swelham pushed a commit to swelham/ember-simple-auth that referenced this pull request Feb 18, 2022
Resolving this deprecation: `DEPRECATION: Using `computed.oneWay` has been deprecated. Instead, import the value directly from @ember/object/computed`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants