Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get() should use no-cors mode #31

Closed
madeleineostoja opened this issue Sep 1, 2016 · 0 comments
Closed

get() should use no-cors mode #31

madeleineostoja opened this issue Sep 1, 2016 · 0 comments
Assignees
@bedeoverend
Labels
enhancement
Milestone
Soon

Comments

@madeleineostoja
Copy link

Fetches made with Simpla.get() should use no-cors mode, which skips preflight header checks (which we don't need). Significantly increased network perf.

Current setup:

  • Average total time for 500 requests: 4062.3ms
  • Average time per request: 8.1ms

Using no-cors mode:

  • Average total time for 500 requests: 837.3ms
  • Average time per request: 1.7ms

Note: Until all elements are migrated to using the SDK then this won't have effect.
@madeleineostoja madeleineostoja added this to the Soon milestone Sep 1, 2016
@madeleineostoja madeleineostoja changed the title get() should use no-cors mode get() should use no-cors mode Sep 1, 2016
@madeleineostoja madeleineostoja mentioned this issue Sep 23, 2016
Closed
bedeoverend added a commit that referenced this issue Sep 27, 2016
@bedeoverend
Merge pull request #43 from simplaio/no-cors
098131c 
Make sure get doesnt send Content-Type headers. fixes #31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bedeoverend bedeoverend

Labels
enhancement
Projects
None yet
Milestone
Soon
Development

No branches or pull requests
2 participants
@bedeoverend @madeleineostoja