Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data state #40

Closed
wants to merge 17 commits into from
Closed

Add data state #40

wants to merge 17 commits into from

Conversation

bedeoverend
Copy link
Contributor

@bedeoverend bedeoverend commented Sep 22, 2016 •
edited

Adds in the data state as per #35.

  • Add data reducer state to track all simpla data
  • get / set / remove should operate on state before touching API
  • get where no data state exists should hydrate from API
  • save state should hold all data and whether they differ from local state to API state
  • save method should set / remove data to API based on if changes have been made

@bedeoverend
ignore symbol-observable in rollup, throws import / export failure
0b62583
@bedeoverend
deep path selection should return undefined even if path missing
6badbe9
@bedeoverend
moved data to api, created new data reducer / actions for updating in…
e6c1790 
…ternal data state
@bedeoverend
change update to set_data_state, add remove_data_state, handle in dat…
0fcc47b 
…a reducer
@bedeoverend
add get and get_data_state actions
0a5017b
@bedeoverend
make data actions more verbose, add set action creator
5a482fc
@bedeoverend
add data remove action
e66e03a
@bedeoverend
add get auto hydrate when state currently undefined
df12c3e
@bedeoverend
export action creators from api actions
d0f12c5
@bedeoverend
add save reducer to state
9fcd1b0
@bedeoverend
add save actions and Simpla.save
1e69771
@bedeoverend
make sure not adding references into the save state
94add48
@bedeoverend
mock api fetch endpoints in beforeEach / teardown in afterEach
ee1af2b
@bedeoverend
encodeURI of uid to preserve things like #
6f4cd53
@bedeoverend
cleanup action tests
c53396c
@bedeoverend
move observe -> observeState, add observe for purely data observation
1d94e0e
@bedeoverend
privatise imports and data in state
449e522
@bedeoverend
Copy link
Contributor Author

@seaneking I also added the change of observe and observeState, they're a big breaking change for Simpla however - simpla-img and simpla-text right now use Simpla.observe which means we couldn't merge this until all elements are ready to be upgraded. Can you see an issue with this? They'll need to be updated to use this anyway, in conjunction with moving to Polymer 2

@madeleineostoja
Copy link

Yep this will have to happen after simpla-text and simpla-img are refactored later this year

@madeleineostoja
Copy link

Or if it needs to happen before then we can just temp patch img and text to observeState (or whatever we settle on for that method name)

@bedeoverend
Copy link
Contributor Author

Closing this in favour of using an overall v2 branch

@bedeoverend bedeoverend deleted the buffer branch September 27, 2016 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bedeoverend @madeleineostoja