Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Simple Icons dependency #12

Merged
merged 2 commits into from Jul 21, 2019
Merged

Update Simple Icons dependency #12

merged 2 commits into from Jul 21, 2019

Conversation

ericcornelissen
Copy link
Contributor

@ericcornelissen ericcornelissen commented Jul 16, 2019

Updates Simple Icons from v1.9.25 to v1.11.0


I had to remove the Elsevier logo from the font as it seems to be too large for fonts.icon-font-buildr gives the following ⬇️ error when building with the Elsevier logo.

events.js:167
      throw er; // Unhandled 'error' event
      ^

Error: Max buffer length exceeded: attribValue
Line: 0
Column: 130705
Char:
    at error (D:\Workspace\simple-icons-font\node_modules\sax\lib\sax.js:651:10)
    at checkBufferLength (D:\Workspace\simple-icons-font\node_modules\sax\lib\sax.js:125:13)
    at SAXParser.write (D:\Workspace\simple-icons-font\node_modules\sax\lib\sax.js:1505:7)
    at SAXStream.write (D:\Workspace\simple-icons-font\node_modules\sax\lib\sax.js:239:18)
    at ReadStream.ondata (_stream_readable.js:666:20)
    at ReadStream.emit (events.js:182:13)
    at addChunk (_stream_readable.js:283:12)
    at readableAddChunk (_stream_readable.js:264:11)
    at ReadStream.Readable.push (_stream_readable.js:219:10)
    at lazyFs.read (internal/fs/streams.js:181:12)
Emitted 'error' event at:
    at SAXStream.saxStream.on.err (D:\Workspace\simple-icons-font\node_modules\svgicons2svgfont\src\index.js:348:12)
    at SAXStream.emit (events.js:187:15)
    at SAXParser.SAXStream._parser.onerror (D:\Workspace\simple-icons-font\node_modules\sax\lib\sax.js:194:10)
    at emit (D:\Workspace\simple-icons-font\node_modules\sax\lib\sax.js:624:35)
    at error (D:\Workspace\simple-icons-font\node_modules\sax\lib\sax.js:653:5)
    at checkBufferLength (D:\Workspace\simple-icons-font\node_modules\sax\lib\sax.js:125:13)
    [... lines matching original stack trace ...]
    at ReadStream.emit (events.js:182:13)
npm ERR! code ELIFECYCLE
npm ERR! errno 1

It seems the path of the SVG is too long for a font, haven't 
investigated yet.

The Elsevier icon was added in v1.10.0 
(simple-icons/simple-icons#1503)
@ericcornelissen ericcornelissen added the dependencies Pull requests that update a dependency file label Jul 16, 2019
Copy link
Contributor

@cactysman cactysman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ericcornelissen ericcornelissen merged commit f460b6c into simple-icons:develop Jul 21, 2019
@ericcornelissen ericcornelissen deleted the dependencies/update-simpleicons branch July 21, 2019 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants