Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future-proof website for guidelines object format. #316

Merged
merged 10 commits into from
Jan 10, 2024

Conversation

adamrusted
Copy link
Member

This PR serves to add some logic around which item we display in the 'guidelines' field. Should mean nothing immediately breaks with the release of PeterShaggyNoble/simple-icons@f26ed39 - and we can adapt to remove the query whenever we decide how we want/need to display trademark notices.

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that if design limitations are restricting us to only be able to display one of the guidelines links for the foreseeable then we should default to the trademark guidelines as they generally have greater legal implications than brand guidelines, and some will often include a link to the brand guidelines. What do you reckon?

@adamrusted
Copy link
Member Author

Yeah, I can expand it out so that if trademark info is there, that gets shared - otherwise, we show the brand guidelines.

PeterShaggyNoble

This comment was marked as resolved.

Adam Rusted and others added 2 commits December 21, 2023 13:01
Co-authored-by: Peter Noble <15157491+PeterShaggyNoble@users.noreply.github.com>
@adamrusted
Copy link
Member Author

@mondeja / @LitoMore - any idea what is causing the website testing issue? Have we missed something in the title checking logic?

@PeterShaggyNoble
Copy link
Member

@mondeja / @LitoMore - any idea what is causing the website testing issue? Have we missed something in the title checking logic?

Looks like it's failing due to changing the casing of "KinoPoisk" to "Kinopoisk" in #10084. But it's not just failing here, it happened during the build of the site on Sunday, too.

@PeterShaggyNoble
Copy link
Member

#317 should fix the issue.

@PeterShaggyNoble PeterShaggyNoble merged commit d00b60a into simple-icons:master Jan 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants