Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request: Knip #10994

Closed
Peanuts-83 opened this issue May 22, 2024 · 4 comments · Fixed by #11006
Closed

Request: Knip #10994

Peanuts-83 opened this issue May 22, 2024 · 4 comments · Fixed by #11006
Labels
new icon Issues or pull requests for adding a new icon

Comments

@Peanuts-83
Copy link

Brand Name

Knip

Website

https://knip.dev/

Popularity Metric

Similarweb

  • nbr of visits from february to april 2024 : 52,359
  • increasing rate : 673.42%

Increasing rate is the key factor to take in consideration I think.

Official Resources for Icon and Color

packages/docs/src/assets

Additional Comments

the icon is orange and white, typo is black and orange, with some white variant.
@Peanuts-83 Peanuts-83 added the new icon Issues or pull requests for adding a new icon label May 22, 2024
@adamrusted
Copy link
Member

Hey @Peanuts-83 - thanks for the submission.
As per our contribution guidelines we don't consider number of visits or rate of increase, only the rank - which is squarely out of scope. Would you have another metric from our list that we can use?

@adamrusted adamrusted added out of scope Issues or pull requests that are beyond the scope of the project assessing Issues or icons that require manual input from a project maintainer before work can begin labels May 22, 2024
@webpro
Copy link

webpro commented May 22, 2024

@uncenter
Copy link
Member

Hey @webpro! Funny seeing you here. Those metrics look good, I'll whip up a PR real quick!

@uncenter uncenter changed the title Knip Request: Knip May 22, 2024
@uncenter uncenter mentioned this issue May 22, 2024
Merged
3 tasks
@adamrusted adamrusted removed assessing Issues or icons that require manual input from a project maintainer before work can begin out of scope Issues or pull requests that are beyond the scope of the project labels May 23, 2024
@webpro
Copy link

webpro commented May 23, 2024

Thanks @uncenter! @Peanuts-83 visited the Discord so I took a look and it looks fantastic 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Knip icon uncenter/simple-icons
4 participants
@webpro @adamrusted @uncenter @Peanuts-83