Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Idea] Add Vue.js integration #1117

Closed
2 of 6 tasks
sh7dm opened this issue Dec 12, 2018 · 15 comments
Closed
2 of 6 tasks

[Idea] Add Vue.js integration #1117

sh7dm opened this issue Dec 12, 2018 · 15 comments

Comments

@sh7dm
Copy link
Task lists! Give feedback

@sh7dm sh7dm commented Dec 12, 2018

Kind of issue

  • Improvement
  • Bug
  • Other, namely:

This issue concerns

  • The NPM Package
  • The website
  • Other, namely:

Description

Add Vue.js integration. I can make it by myself and contribute.

Use case: Vue.js application

@gabrieledarrigo
Copy link
Contributor

@gabrieledarrigo gabrieledarrigo commented Dec 12, 2018

@sh7dm I'd like to help on this, what are your plans on the integration?

@sh7dm
Copy link
Author

@sh7dm sh7dm commented Dec 12, 2018

@gabrieledarrigo I want to add simple-icon component.

@gabrieledarrigo
Copy link
Contributor

@gabrieledarrigo gabrieledarrigo commented Dec 15, 2018

But maybe it's worth to think to iterate on the component on a separate repository, maybe as an independent npm package?

@ericcornelissen
Copy link
Member

@ericcornelissen ericcornelissen commented Dec 15, 2018

I like the suggestion and I'm in for supporting a VueJS component. As @gabrieledarrigo, I think it is better to do this in a separate repository.

If you want to @sh7dm, you can start working on it and we can include it into the SimpleIcons organisation once there is some basic working version 👍

@sh7dm
Copy link
Author

@sh7dm sh7dm commented Dec 15, 2018

@ericcornelissen I can create repo in my account. How do you want this package called? I think something like vue-simple-icons will be great.

@gabrieledarrigo
Copy link
Contributor

@gabrieledarrigo gabrieledarrigo commented Dec 15, 2018

Hi @sh7dm, I'm glad to help if you like 😊, but tell me how!

@sh7dm
Copy link
Author

@sh7dm sh7dm commented Dec 15, 2018

@gabrieledarrigo I'm going to create a repo called vue-simple-icons. What do you think about the name? Sure, you will be able to contribute to it.

@gabrieledarrigo
Copy link
Contributor

@gabrieledarrigo gabrieledarrigo commented Dec 15, 2018

@sh7dm
Copy link
Author

@sh7dm sh7dm commented Dec 15, 2018

@gabrieledarrigo I will create the repo! Let's make it using TypeScript, do you agree?

@gabrieledarrigo
Copy link
Contributor

@gabrieledarrigo gabrieledarrigo commented Dec 15, 2018

Agree at all! Let share the link so that I (we?!) can see how to help : )

@sh7dm
Copy link
Author

@sh7dm sh7dm commented Dec 15, 2018

@gabrieledarrigo OK! 👍

@sh7dm
Copy link
Author

@sh7dm sh7dm commented Dec 15, 2018

I'm gonna use Rollup as a bundler, do you agree?

@ericcornelissen
Copy link
Member

@ericcornelissen ericcornelissen commented Dec 16, 2018

It is great to see you picking up this feature @sh7dm 😃 The name is fine with me, but as long as it is not published on (e.g.) NPM it can be changed I think. If I find the time I might try to contribute as well!

As for discussion on the details of the project, I think it is better to discuss that in the repo itself.

@sh7dm
Copy link
Author

@sh7dm sh7dm commented Dec 16, 2018

@ericcornelissen OK! If you have any ideas, please open issue in https://github.com/sh7dm/vue-simple-icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants