Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NestJs #2926

Closed
EdoGp opened this issue Apr 11, 2020 · 4 comments · Fixed by #3113
Closed

NestJs #2926

EdoGp opened this issue Apr 11, 2020 · 4 comments · Fixed by #3113
Assignees
@EdoGp @PeterShaggyNoble
Labels
good first issue Issues we believe are simple and a good first stab at contributing to the project new icon Issues or pull requests for adding a new icon

Comments

@EdoGp
Copy link

EdoGp commented Apr 11, 2020

**Name:Nestjs
**Website:https://nestjs.com/
Official resources for icon and color:

https://nestjs.com/
@EdoGp EdoGp added the new icon Issues or pull requests for adding a new icon label Apr 11, 2020
@ericcornelissen ericcornelissen added the good first issue Issues we believe are simple and a good first stab at contributing to the project label Apr 12, 2020
@ericcornelissen
Copy link
Contributor

There is an SVG of their logo in the website header 👍

@EdoGp, are you interested in contributing this icon to the project? You can read more about that in our Contributing Guidelines.

EdoGp added a commit to EdoGp/simple-icons that referenced this issue Apr 13, 2020
@EdoGp
Add Insomnia (simple-icons#2926)
d32bae7
EdoGp added a commit to EdoGp/simple-icons that referenced this issue Apr 13, 2020
@EdoGp
Add NestJs (simple-icons#2926)
3d1be75
@PeterShaggyNoble
Copy link
Member

Alexa rank: ~31.9k
Suggested colour: #e0234e from the SVG Eric linked above

@PeterShaggyNoble PeterShaggyNoble self-assigned this Apr 29, 2020
@PeterShaggyNoble
Copy link
Member

Man, their SVGs are just a complete mess of minor imperfections and excessive points but I can't tell if that's intentional so that it appears "rough around the edges" so do we try to clean it up for them or leave it as is?

@PeterShaggyNoble PeterShaggyNoble added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Apr 29, 2020
@PeterShaggyNoble PeterShaggyNoble removed their assignment Apr 29, 2020
@ericcornelissen
Copy link
Contributor

Man, their SVGs are just a complete mess of minor imperfections and excessive points but I can't tell if that's intentional so that it appears "rough around the edges" so do we try to clean it up for them or leave it as is?

To err on the safe side I would just leave the logo as is.

@PeterShaggyNoble PeterShaggyNoble self-assigned this May 18, 2020
@PeterShaggyNoble PeterShaggyNoble removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label May 18, 2020
@PeterShaggyNoble PeterShaggyNoble mentioned this issue May 26, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EdoGp EdoGp

@PeterShaggyNoble PeterShaggyNoble

Labels
good first issue Issues we believe are simple and a good first stab at contributing to the project new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add NestJS PeterShaggyNoble/simple-icons
3 participants
@ericcornelissen @EdoGp @PeterShaggyNoble