-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include filenames in simple-icons.json as well as the human-readable title #989
Comments
I was imagining a process where I would have a list of human readable titles (e.g. But it looks like an alternative option might be to install simple-icons with NPM and then copy the contents of |
I'm personally not very familiar with Drupal, what process are you using to get the most up to date version of SimpleIcons? I understand that replicating the
If at all possible, I think using the NPM package would be the easiest solution for both of us. If it would make you life easier, it would be possible for us to somehow include the filename in the icon data as well. |
Hi @ericcornelissen, that's a very good point about the contributors! I think using the object exported in
|
Hey @philwolstenholme, it has been a while but the property you asked for is now (more or less) there, namely the slug property (you will have to add I'm closing this issue for now, if you feel like your issue has not yet been resolved, feel free to reopen 😄 |
Hi,
I'm trying to include simple-icon icons in a Drupal module. I'm thinking of parsing the
simple-icons.json
file to show all the icons available to the user to display in their footer (e.g. for social links), but then I have to guess at the filenames based on looking through scripts likesimple-icons/scripts/utils.js
and by duplicating thetitleToFilename
function in PHP.That's all doable, but if an update to simple-icons changes how
titleToFilename
works, then all my icon URLs will no longer be accurate.I could peg my local copy of social-icons to a particular version, instead of whatever is the latest version, and then that way my
titleToFilename
function would always match my icon filenames, but then my users wouldn't benefit from any updates to simple-icons, e.g. if a brand re-branded and their icon changed.It would be great if it was possible to programmatically get a list of all the available icons, and see both their human readable title and their filename.
The text was updated successfully, but these errors were encountered: