Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perplexity: New Icon #10268

Closed
wants to merge 10 commits into from
Closed

Conversation

durgeshgowdac
Copy link
Contributor

@durgeshgowdac durgeshgowdac commented Jan 11, 2024

Issue: #10262

Similarweb rank:

Global Rank: 1,089
Link: https://www.similarweb.com/website/perplexity.ai/

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Jan 11, 2024
@durgeshgowdac
Copy link
Contributor Author

@PeterShaggyNoble There's no conflict. You can review it and let me know if there's any changes needed. You can merge it.

Thank You,
@durgeshgowdac

@PeterShaggyNoble PeterShaggyNoble changed the title Perplexity Add Perplexity Jan 11, 2024
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @durgeshgowdac 👍🏻 But I'm seeing some differences between your version (in red below) and both the Wikimedia version (green) and the logo on their website (black). As there is an SVG available on their website, that's the version we should run with.

Also, for the colour, I'm getting #1fb8cd from the website's stylesheet.

@durgeshgowdac
Copy link
Contributor Author

@PeterShaggyNoble Can I know How you compared the above svgs?

@PeterShaggyNoble
Copy link
Member

Just overlaid all 3 in different colours.

@durgeshgowdac durgeshgowdac changed the title Add Perplexity Perplexity: New Icon Jan 11, 2024
@durgeshgowdac
Copy link
Contributor Author

Just overlaid all 3 in different colours.

I was asking which software you use.
@PeterShaggyNoble Things aside, I've finished the requested changes. Please check if it satisfies all your requirements.

  • I've changed the source and color in json.
  • I changed the svg to be based on the website instead of wikipedia.

@PeterShaggyNoble
Copy link
Member

Oh, sorry 🤦🏻‍♂️ I use Inkscape.

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing some minor differences now, @durgeshgowdac, with your version in red.

But, as Inkscape often doesn't play nice with strokes, I'll ask one of the other @simple-icons/maintainers to have a look at it, too, before you make any changes.

Copy link
Member

@PratyushJayachandran PratyushJayachandran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon fetching SVG from their website, I am only getting a path with no strokes. Am I missing something?
image

@PeterShaggyNoble
Copy link
Member

@PratyushJayachandran, you'll need to grab the stroke-width from the CSS.

Copy link
Member

@PratyushJayachandran PratyushJayachandran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all the source SVG is so misaligned. After aligning it, when comparing I see a lot of differences!
I found a better aligned SVG on the pop-up window on the website as shown here:
image

@adamrusted
Copy link
Member

@durgeshgowdac - are you able to create using the SVG source @PratyushJayachandran discovered? I'll be able to review once that's merged in.

@durgeshgowdac
Copy link
Contributor Author

@PeterShaggyNoble I've tried many times. Everytime, there is a marginal error. Can you assign it to someone else.
Thank You

@PeterShaggyNoble PeterShaggyNoble added the abandoned Pull requests that have been abandoned by the contributor label Feb 8, 2024
@durgeshgowdac durgeshgowdac deleted the perplexity branch February 17, 2024 13:07
@21st-centuryman 21st-centuryman mentioned this pull request Feb 17, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned Pull requests that have been abandoned by the contributor new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants