Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add babbel icon #10655

Closed
wants to merge 3 commits into from
Closed

Add babbel icon #10655

wants to merge 3 commits into from

Conversation

imskr
Copy link

@imskr imskr commented Mar 15, 2024

Issue: closes #10654

Popularity metric:

The similar web rank is 5595 https://www.similarweb.com/website/babbel.com

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

N/A

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Mar 15, 2024
@imskr
Copy link
Author

imskr commented Mar 15, 2024

I don't understand why the lint is failing even though the dimensions are correct

@adamrusted
Copy link
Member

Hey @imskr - looking at the icon you've submitted it seems the actual path itself doesn't meet the edges of the viewbox. As part of our contribution guidelines, we ask that the largest dimension (in this case, the width) be set to exactly 24px. Once you do that, the linter should have a much easier time.

@adamrusted
Copy link
Member

Are you still working on this one, @imskr?

@adamrusted adamrusted added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Mar 28, 2024
@imskr
Copy link
Author

imskr commented Mar 28, 2024

Thanks @adamrusted for the review. I am not very comfortable with SVG paths. Is it something you can help me with it?

@adamrusted
Copy link
Member

Which editing software are you using @imskr? There are different steps to correct this based on which one you're using.

@imskr
Copy link
Author

imskr commented Mar 28, 2024

Which editing software are you using @imskr? There are different steps to correct this based on which one you're using.

I haven't had the chance to look at it tbh as I have never used it before for these works @adamrusted

@adamrusted
Copy link
Member

Fair enough! Worth a read of this file to go through how we recommend editing files and adding them to a PR. There are various software options there - and once you settle on one we can advise better on how to get the linter to pass.

@adamrusted
Copy link
Member

Did you still want to work on this @imskr?

@imskr
Copy link
Author

imskr commented May 20, 2024

Sorry I do not have any bandwidth to work on this @adamrusted

@imskr imskr closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Babbel
2 participants