-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add babbel icon #10655
Add babbel icon #10655
Conversation
I don't understand why the lint is failing even though the dimensions are correct |
Hey @imskr - looking at the icon you've submitted it seems the actual path itself doesn't meet the edges of the viewbox. As part of our contribution guidelines, we ask that the largest dimension (in this case, the width) be set to exactly 24px. Once you do that, the linter should have a much easier time. |
Are you still working on this one, @imskr? |
Thanks @adamrusted for the review. I am not very comfortable with SVG paths. Is it something you can help me with it? |
Which editing software are you using @imskr? There are different steps to correct this based on which one you're using. |
I haven't had the chance to look at it tbh as I have never used it before for these works @adamrusted |
Fair enough! Worth a read of this file to go through how we recommend editing files and adding them to a PR. There are various software options there - and once you settle on one we can advise better on how to get the linter to pass. |
Did you still want to work on this @imskr? |
Sorry I do not have any bandwidth to work on this @adamrusted |
Issue: closes #10654
Popularity metric:
The similar web rank is 5595 https://www.similarweb.com/website/babbel.com
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
N/A