Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch single-quotes for double-quotes to allow scripts to run on Powershell. #10727

Merged
merged 2 commits into from Mar 29, 2024

Conversation

adamrusted
Copy link
Member

The husky hooks were causing issue on my machine, which boils down to the use of single-quotes in our package.json commands. Amending those make the commands run universally.

@mondeja mondeja self-requested a review March 28, 2024 13:39
package.json Show resolved Hide resolved
@mondeja mondeja added the meta Issues or pull requests regarding the project or repository itself label Mar 28, 2024
Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey, thanks! I'll check another solution for the svglint script.

@mondeja mondeja merged commit 601e6ff into simple-icons:develop Mar 29, 2024
3 checks passed
@adamrusted adamrusted deleted the fix/powershell-commands branch March 30, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues or pull requests regarding the project or repository itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants