Update labels and URLs for outdated-icons #10802
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mondeja
requested changes
Apr 11, 2024
| @@ -8,11 +8,11 @@ body: | |||
| attributes: | |||
| value: | | |||
| Before opening a new issue, make sure it isn't covered by an existing issue. | |||
| Please search for [issues with the `icon outdated` label][icon-outdated-issues] | |||
| Please search for [issues with the `update-icon/data` label][update-icon/data] | |||
There was a problem hiding this comment.
Suggested change
| Please search for [issues with the `update-icon/data` label][update-icon/data] | |
| Please search for [issues with the `update icon/data` label][update-icon/data] |
There was a problem hiding this comment.
Yes, let's drop the PR in favor of @adamrusted's #10804.
|
I still have concerns about those label naming changes. I feel that our labels are not as accurate as before. We can no longer find all issues related to icon updates or icon removal through a certain label. The semantics are not as easy to understand as before. These may not be friendly to our first-time contributors and issue authors. If you want to adopt these changes, you can review this one instead: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The label in URLs should be updated since we renamed it.