Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nvm icon #11041

Merged
merged 3 commits into from
May 28, 2024
Merged

Add nvm icon #11041

merged 3 commits into from
May 28, 2024

Conversation

CodeShakingSheep
Copy link
Contributor

@CodeShakingSheep CodeShakingSheep commented May 27, 2024 •
edited
Loading

image

Issue: closes #10075

Popularity metric:
It has ~76.4k stars on GitHub. See https://github.com/nvm-sh/nvm

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Resized, unified paths, optimized.

@simple-icons simple-icons bot added the new icon Issues or pull requests for adding a new icon label May 27, 2024
uncenter
uncenter previously requested changes May 27, 2024
View reviewed changes
Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-05-27 at 11 55 41 (Inkscape)

Seeing some differences when compared to the source. Looks like there might have been some strokes that you didn't convert?

@CodeShakingSheep
Copy link
Contributor Author

Seeing some differences when compared to the source. Looks like there might have been some strokes that you didn't convert?

Yes, you're right. I just converted the strokes.

adamrusted
adamrusted approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks spot on now, thanks @CodeShakingSheep! 🎉

@adamrusted adamrusted merged commit 9e747bd into simple-icons:develop May 28, 2024
3 checks passed
@simple-icons simple-icons bot mentioned this pull request Jun 2, 2024
Merged
simple-icons bot added a commit that referenced this pull request Jun 2, 2024
@simple-icons
Release 14 new icons and 3 updated icons (v12.1.0)
1a4282f 
# New Icons

- Apache HBase (#11042) (@CodeShakingSheep)
- Apache Superset (#10871) (@10xLaCroixDrinker)
- Babylon.js (#11004) (@jglamp)
- Coder (#11030) (@anhthang)
- CSS Design Awards (#10540) (@stefanobartoletti)
- Dictionary.com (#11043) (@anhthang)
- Dovetail (#11029) (@anhthang)
- Knip (#11006) (@uncenter)
- LazyVim (#11028) (@21st-centuryman)
- Modal (#11050) (@anhthang)
- nvm (#11041) (@CodeShakingSheep)
- Rclone (#11005) (@CodeShakingSheep)
- Taipy (#11049) (@anhthang)
- wgpu (#10358) (@elliotwutingfeng)

# Updated Icons

- Acura (#11012) (@jglamp)
- Redis (#11019) (@anhthang)
- SoundCloud (#11000) (@aheneneu)
@CodeShakingSheep CodeShakingSheep deleted the add-nvm-icon branch June 25, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrusted adamrusted adamrusted approved these changes

@uncenter uncenter uncenter left review comments

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: NVM
3 participants
@CodeShakingSheep @adamrusted @uncenter