Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permissions to Remove Labels workflow #11051

Merged
merged 2 commits into from
May 28, 2024

Conversation

mondeja
Copy link
Member

@mondeja mondeja commented May 28, 2024

Changes the event from pull_request_target to pull_request also. Currently the workflow is using an app token, so it's not needed to run in the base side.

@mondeja mondeja requested a review from LitoMore May 28, 2024 11:25
@simple-icons simple-icons bot added the meta Issues or pull requests regarding the project or repository itself label May 28, 2024
@mondeja mondeja changed the title Add permissions to remove labels workflow Add permissions to Remove Labels workflow May 28, 2024
@mondeja mondeja merged commit 346d474 into simple-icons:develop May 28, 2024
3 checks passed
@mondeja mondeja deleted the remove-labels-permissions branch May 28, 2024 12:37
@mondeja
Copy link
Member Author

mondeja commented May 28, 2024

Seems that pull_request will not work on forks because app-id environment variable is not available there (see this run), reverted at 01dd04f.

@LitoMore why the app-token action recommends storing it in a environment variable? It wouldn't be better in a secret?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues or pull requests regarding the project or repository itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants