Add CodeCrafters Icon #11252
Open
Add CodeCrafters Icon #11252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simple-icons
bot
added
the
new icon
PratyushJayachandran
requested changes
Jun 24, 2024
There was a problem hiding this comment.
Can you try with the other icon: https://github.com/codecrafters-io/frontend/blob/2f15115b73843fea57a412ce243ff1cedb5e69f7/public/assets/images/logo/logomark-color.svg?
| { | ||
| "title": "CodeCrafters", | ||
| "hex": "00CEDE", | ||
| "source": "https://github.com/codecrafters-io/frontend/blob/2f15115b73843fea57a412ce243ff1cedb5e69f7/public/assets/images/logo/outline-color.svg" |
There was a problem hiding this comment.
Suggested change
| "source": "https://github.com/codecrafters-io/frontend/blob/2f15115b73843fea57a412ce243ff1cedb5e69f7/public/assets/images/logo/outline-color.svg" | |
| "source": "https://github.com/codecrafters-io/frontend/blob/2f15115b73843fea57a412ce243ff1cedb5e69f7/public/assets/images/logo/logomark-color.svg" |
My opinion is that the other logo is more appropriate since it used in their website too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: closes #11251
Popularity metric:
The similar web ranking is 77,248: https://www.similarweb.com/website/codecrafters.io
Checklist
_data/simple-icons.jsonviewboxis0 0 24 24Description
Color was determined using color blender tool linked on contributing page.