-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GMC icon #11265
base: develop
Are you sure you want to change the base?
Add GMC icon #11265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this @DevangGarg - there are a couple of points below, and I'd appreciate you completing the PR template in your post above to give us proper metrics for measuring popularity, etc.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This icon does not at all match the one from the URL listed as source.
{ | ||
"title": "GMC", | ||
"hex": "E21836", | ||
"source": "https://www.gmc.com/content/dam/gmc/na/us/english/primary-nav-icons/GMC-153x28.svg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per https://github.com/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md#source-guidelines we should avoid linking directly to the SVG files themselves and rather link to the page that has the SVG displayed on it.
Depending on the answer from General Motors we may need to remove the Chevrolet, Cadillac, and GM Icon |
Correct. And #11247 would have to be closed. |
Has someone asked for permission on this one yet? |
I think that General motors has said to remove the icon. Do I need to continue with this task? |
Where have they said this? Only thing I can see on this thread is me sharing the link to their terms. |
Issue: closes #11248.
Popularity metric:
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description