Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SpaceX #1314

Merged
merged 2 commits into from Jun 15, 2019
Merged

Add SpaceX #1314

merged 2 commits into from Jun 15, 2019

Conversation

birjj
Copy link
Contributor

@birjj birjj commented Mar 25, 2019

Issue: #1257

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Big thanks to @metaa for finding the official SVG.

The "X" logomark is chosen over the full wordmark for reasons explained in #1257
Now that I see it, I am starting to doubt that decision though. This is mostly due to the very off-center nature of the logomark, which doesn't mesh well with how Simple Icons is usually used. Two ways to solve this: use a version cropped to a square (like SpaceX use in their favicon) or use the full wordmark (my preferred solution) - or just use the logomark as in this PR.




Fixes simple-icons#1257
The "X" logomark is chosen over the full wordmark for reasons discussed
in simple-icons#1257
@davidklebanoff
Copy link
Contributor

I think you chose the correct icon for the PR. It's consistent with their Instagram, Twitter, LinkedIn, etc. and I think keeps in line with the rest of Simple Icons.

It is a little odd in its positioning, but so are a lot of other icons. It's a known issue and this is where #477 comes into play. But even after #477 it may be off, as their brand seems to consider the proper center of the icon to be the middle of the X.

As for the color, I don't think white is correct. If one were to base the decision on their current website and social media, and followed the discussion in #1202, it should be black. However, as someone who has been following the company for a while and watched a bunch of launches, I would argue their brand color may actually be blue (unless it's changed recently). The logo on their rockets, capsule, and launch facility are all blue. So I'm not sure what it should be.

@cactysman
Copy link
Contributor

cactysman commented Mar 25, 2019

As for the color, I don't think white is correct. [...] it should be black. However, [...] the logo on their rockets, capsule, and launch facility are all blue. So I'm not sure what it should be.

I just dug out this SVG on Wikipedia (could've considered checking Wikipedia first 😅) and that one is blue aswell, though the X also has some gray.

@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Mar 25, 2019
@ericcornelissen
Copy link
Contributor

Not sure how official this resource is (at least it matches the SVG on Wikipedia) but SchemeColor.com also lists #005288, at least for the SpaceX Logo (they also have an entry for the SpaceX website).

Another resource I found is this pdf which also uses blue (doesn't specify a hex though...), but again I'm not sure how official it is.

@cactysman
Copy link
Contributor

cactysman commented Mar 25, 2019

The PDF uses the same blue by the way.

But let's wait for a reply.

@ericcornelissen ericcornelissen added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Apr 5, 2019
@ericcornelissen
Copy link
Contributor

Since I don't think there is going to be response from Elon anytime soon... Do we stay with the current color or switching to blue (probably #005288) @birjolaxew / @davidklebanoff ?

@cactysman
Copy link
Contributor

I'd use the blue since their logos use blue.

@birjj
Copy link
Contributor Author

birjj commented Jun 15, 2019

I've updated the color to blue. I'll let another maintainer merge this in.

@ericcornelissen ericcornelissen merged commit 7adf620 into simple-icons:develop Jun 15, 2019
@ericcornelissen ericcornelissen removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Jun 15, 2019
@ericcornelissen
Copy link
Contributor

Thanks for your work on this way back @birjolaxew 👍

GitHubXiaoZ pushed a commit to GitHubXiaoZ/simple-icons that referenced this pull request Jun 25, 2019
* Add SpaceX

The "X" logomark is chosen over the full wordmark for reasons discussed
in simple-icons#1257

* Update SpaceX color to blue

Reasoning found in simple-icons#1314

---

Closes simple-icons#1257
@PeterShaggyNoble PeterShaggyNoble mentioned this pull request Jun 3, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants