Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Fedora icon #1423

Merged
merged 1 commit into from
May 23, 2019
Merged

Added Fedora icon #1423

merged 1 commit into from
May 23, 2019

Conversation

hylickipiotr
Copy link
Contributor

@hylickipiotr hylickipiotr commented May 22, 2019

Issue: #1160

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

I've use the oficial Fedora logo, but to display in only black-white, I've removed brighter line inside the logo, so it is simple to see is the 'f' like the Fedora. If I colorized this line white, it would be infinity sign.

Color was got from official Fedora logo guidline #294172

image

@birjj
Copy link
Contributor

birjj commented May 22, 2019

I could've sworn there was an existing discussion on the Fedora logo, but I can't find it for the life of me. Must be something I've imagined ¯\_(ツ)_/¯

Monochromization of this one is difficult. There are a couple different solutions to this in other icon packages (e.g. FontAwesome uses hashing, while font-logos use the solution also chosen in this PR). There's some good discussion on Fedora's own issue, including a suggestion that might work with the current logo (although to match the current logo this would need both ends of the "f" marked):

It should also be noted that they have a new logo which was approved 2 months ago. They have not yet started using it, so we should stick with the old logo (the one in this PR) until they do.

I am ok with the monochromization this PR currently has. Will wait for another maintainer (@davidklebanoff @ericcornelissen) before merging.

@birjj birjj added the new icon Issues or pull requests for adding a new icon label May 22, 2019
@ericcornelissen ericcornelissen merged commit a18622d into simple-icons:develop May 23, 2019
@ericcornelissen
Copy link
Contributor

ericcornelissen commented May 23, 2019

I personally feel like the approach taken by @hylickipiotr is more recognizable than the one shown in @birjolaxew comment (but I'm not super familiar with the logo), so I went ahead and merged it.

If anyone disagrees they can continue a discussion in this thread or open a separate issue 🙂

Anyway, thanks @hylickipiotr for adding this icon to the collection 🎊

GitHubXiaoZ pushed a commit to GitHubXiaoZ/simple-icons that referenced this pull request Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants