Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GNOME #2177

Merged
merged 4 commits into from Dec 20, 2019
Merged

Add GNOME #2177

merged 4 commits into from Dec 20, 2019

Conversation

PeterShaggyNoble
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble commented Dec 19, 2019

GNOME

Issue: Closes #2160

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Rejected alternative:
GNOME

@runxel runxel added the new icon Issues or pull requests for adding a new icon label Dec 19, 2019
Copy link
Member

@runxel runxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@PeterShaggyNoble
Copy link
Member Author

Actually, @runxel, having thought some more on it, I think a case can be made for either colour. We have precedent for using a brand's colour, despite it not being used in their logo or icons (Slack immediately springs to mind, for example). The difference here, of course, is that, as you pointed out, GNOME explicitly state that their logo should only appear in black or white.

What do the other @simple-icons/maintainers think?

@birjj
Copy link
Contributor

birjj commented Dec 20, 2019

We generally consider the color in our data to be the brand guideline; this doesn't necessarily equal the logo color, so I'm in favor of the blue currently in this PR.

That being said, I think that including the "GNOME" letters would be right here, simply because they seem super consistent with doing so whenever they use the logo to refer to their brand. Even their favicon is logo + wordmark (although confusingly not the vertical version ¯\_(ツ)_/¯). I feel like we've recently set precedence for not including TM/R, so let's continue that trend.

@PeterShaggyNoble
Copy link
Member Author

Updated to the alternative version of the icon.

@birjj
Copy link
Contributor

birjj commented Dec 20, 2019

👍 Looks good! Thanks for updating @PeterShaggyNoble.

@birjj birjj merged commit ee450c5 into simple-icons:develop Dec 20, 2019
birjj added a commit that referenced this pull request Dec 24, 2019
New icons:

- Dart (#2106)
- Audi (#2065)
- Pi-hole (#2084)
- Fijutsu (#2076)
- Uber Eats (#2078)
- RocketMQ (#2112)
- ZeroMQ (#2115)
- Cordova (#2027)
- XMPP (#2085)
- V (#2056)
- Cryengine (#2079)
- Mercedes (#2114)
- Corona Renderer (#2129)
- Fujifilm (#2131)
- Parse.ly (#2138)
- Nutanix (#2098)
- Publons (#2130)
- Webmin (#2132)
- X.Org (#2122)
- Notist (#2123)
- Directus (#2142)
- DLNA (#2080)
- Ember.js (#2143)
- Waze (#2146)
- StackPath (#2145)
- Jinja (#2144)
- Floatplane (#2140)
- Box (#2159)
- WhiteSource (#2121)
- Vodafone (#2096)
- WebAuthn (#2104)
- Xamarin (#2176)
- Dunked (#2178)
- Stencyl (#2184)
- Zend (#2171)
- Zend Framework (#2171)
- OpenSSL (#2043)
- Crehana (#2045)
- Lufthansa (#2113)
- iOS (#2147)
- Broadcom (#2163)
- Volkswagen (#2150)
- GNOME (#2177)
- cPanel (#2173)
- Coinbase (#1845)
- Sketch (#2208)
- ICON (#2165)

Updated icons

- Node.js (#2134)
- Meetup (#2062)
- GitLab (#2192)
@PeterShaggyNoble PeterShaggyNoble mentioned this pull request Jan 23, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GNOME
3 participants