Add Pixabay #2301
Merged
Add Pixabay #2301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See my comment at #2153. |
ericcornelissen
suggested changes
Jan 16, 2020
There was a problem hiding this comment.
Based on my comment in the issue I would like to see "pixabay" removed from the SVG 🙂 But let me know if anyone disagrees!
|
Thanks for the feedback, guys; I've updated the icon in the PR. |
ericcornelissen
approved these changes
Jan 16, 2020
There was a problem hiding this comment.
Looks good to me know 👍 I will leave the final review to @foo-dogsquared
foo-dogsquared
approved these changes
Jan 17, 2020
There was a problem hiding this comment.
All looks good to me and no problems sighted.
Thanks @PeterShaggyNoble for taking care of this one.
ericcornelissen
added a commit
that referenced
this pull request
Jan 20, 2020
New icons - Bulma (#2290) - Bluetooth (#2293) - Google Assistant (#2296) - Emby (#2304) - OpsLevel (#1890) - ioBroker (#2302) - Douban (#2303) - Apache Pulsar (#2314) - Amazon Lumberyard (#2232) - Bandsintown (#2319) - Discogs (#2320) - ChartMogul (#2308) - Just Eat (#2109) - KeePassXC (#2273) - Parity Substrate (#2324) - Slackware (#2289) - Grunt (#2321) - Transport for Ireland (#2323) - Quest (#2325) - Skype for Business (#2337) - Rhino (#2197) - Wear OS (#2305) - NetApp (#2327) - Kyocera (#2328) - Fortinet (#2329) - Citrix (#2330) - Apache Ant (#2342) - protocols.io (#2344) - Google Maps (#2196) - The Register (#2346) - Tide (#2307) - Mocha (#2347) - Citroën (#2359) - Opel (#2361) - Flood (#2349) - Google Lens (#2354) - Google Fit (#2355) - LogMeIn (#2356) - Das Erste (#2198) - CD Projekt (#2292) - HelloFresh (#2295) - Polymer Project (#2353) - Jenkins X (#2333) - Material Design Icons (#2371) - Apache Maven (#2374) - LMMS (#2350) - FedRAMP (#2318) - Semantic Web (#2372) - Claris (#2381) - XAMPP (#2086) - Pixabay (#2301) - AngularJS (#2379, b95baf4) - Aiqfome (#2400) - Airbus (#2396) Updated icons - SourceForge (#2294) - Xamarin (#2297) - Fedora (#2300) - Brave (#2362) - Microsoft Edge (#2378)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Closes #2153
Checklist
_data/simple-icons.jsonviewboxis0 0 24 24Description
I went with the green from their website stylesheet but there are some possible alternatives in #2153 as well as an alternative treatment of the icon.