Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Consul #2393

Closed
wants to merge 5 commits into from
Closed

Add Consul #2393

wants to merge 5 commits into from

Conversation

mhf-ir
Copy link
Contributor

@mhf-ir mhf-ir commented Jan 17, 2020

Issue:

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Alexa rank is about 197K

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Jan 17, 2020
@foo-dogsquared
Copy link
Contributor

Basing from the monochrome SVG file (consul-monochrome.svg) from the given brand kit.

(Your version is yellow and the official SVG is in black.)

2020-01-18-01-05-53

It doesn't matter much since the official SVG is malformed.
(Isn't that fun...)

2020-01-18-01-32-08

2020-01-18-01-30-31

2020-01-18-01-32-02

Here's the malformed sections of the official SVG in highlight.
(The SVG file in picture is consul-black.svg but it doesn't matter either since it also has the same problems as all of the other SVGs.)

2020-01-18-01-34-56

The AI version, for whatever reason, has less problems (and way more subtle unless closely inspected).
I recommend to start with that and fix the highlighted sections.

2020-01-18-01-44-51

@mhf-ir
Copy link
Contributor Author

mhf-ir commented Jan 17, 2020

Update from official hashicorp https://www.hashicorp.com/brand:
https://s3.amazonaws.com/hashicorp-marketing-web-assets/brand/Consul.zip
Consul_VerticalLogo_MonochromeTonal.svg

@foo-dogsquared
Copy link
Contributor

foo-dogsquared commented Jan 20, 2020

The malformations are still present in the updated version.

2020-01-21-00-00-16

2020-01-21-00-00-33

I advise to use the AI version of the logo (for reference, I mainly inspected Consul_PrimaryLogo_Black.ai) since it has less malformations than the SVG versions.

@mhf-ir
Copy link
Contributor Author

mhf-ir commented Jan 20, 2020

I think you must ask Consul to fix it. If we fix so we have change problem.
All version have same issue:
Screenshot from 2020-01-20 20-25-26
Screenshot from 2020-01-20 20-24-18
Screenshot from 2020-01-20 20-23-30
Screenshot from 2020-01-20 20-27-30

@mhf-ir
Copy link
Contributor Author

mhf-ir commented Jan 23, 2020

Should i fix original icon? or ask for Hashicorp to fix it 😃 ?

@mhf-ir
Copy link
Contributor Author

mhf-ir commented Jan 23, 2020

@PeterShaggyNoble
Copy link
Member

Closing as abandoned due to this comment. If anyone else would like to take this on, please feel free to open a new PR or issue.

@PeterShaggyNoble PeterShaggyNoble added the abandoned Pull requests that have been abandoned by the contributor label Jan 31, 2020
@PeterShaggyNoble PeterShaggyNoble mentioned this pull request May 13, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned Pull requests that have been abandoned by the contributor new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants