Add Ardour

[mondeja]

Issue: Closes #2909

Checklist

• I updated the JSON data in _data/simple-icons.json
• I optimized the icon with SVGO or SVGOMG
• The SVG viewbox is 0 0 24 24

Description

Source SVG file from here.

[PeterShaggyNoble]

Thanks for the PR, @mondeja.

I think we can go with the icon without the text here.

[PeterShaggyNoble]

Also, the source URL should be the URL of the SVG used on GitHub, including the commit hash. See our contributing guidelines for more details.

[mondeja]

Updated, here is the new preview:

[PeterShaggyNoble]

Thanks, @mondeja 👍

Firstly, one minor issue: your path is coming in at 24.001 wide. This can usually be fixed by increasing the precision.

Secondly, to help us compare like with like, could you let us know which specific version of their icon you based yours on? There are some terrible inconsistencies between files and even within individual files 🙄 The comparison below, for example, shows the top-left icon in this file overlaid in red with the top-right one. I've compared your version with 3 different versions from their repo and all have different inconsistencies so I suspect I'm not using the one you used.

Finally, for the source URL, if you used the app-icon_tango.svg file linked above, for example, it should be https://github.com/Ardour/ardour/blob/9fac6139ea40ee2ba5af1415c302c61fee6a13aa/tools/misc_resources/app-icon_tango.svg - to get the file URL with the latest commit hash included hit y on your keyboard while viewing the source file in your browser.

[mondeja]

I've used the file ardour_bw.svg. I'm not sure of what icon to use. Maybe we need to ping Ardour developers.

[PeterShaggyNoble]

I've used the file ardour_bw.svg.

That was one of the ones I tried in my comparisons, too. There are a couple of minor discrepancies that will need to cleaned up before we can merge this (see screenshots below for examples, with your version in red).

I'm not sure of what icon to use.

As they're all from an official source, it's fine to use any of them. My first preference would be to ardour_bw.ai, followed by ardour_bw.svg.

Maybe we need to ping Ardour developers.

Certainly can't hurt 👍 Pinging @pauldavisthefirst as the top contributor to that repo for feedback. If we don't hear back in a few days.

[thorwil]

Hi, I’m the creator of Ardour’s logo. There has been an update several years ago. The old version has irregular “teeth” and happens to be in the first image of this thread. The new version has evenly spaced “teeth”. Since I never had commit access, as it would have been silly for one file here, one file there, and since years have passed, I don’t know what is what in there, except that all originals are SVG created with Inkscape.

ardour_for_simple-icons.zip: current version, including low-resolution versions derived from the original Tango-themed icon set.

[mondeja]

Thanks @thorwil. I will update the logo soon.

[mondeja]

I've used the best resolution version at the top of the file provided at the comment above and setted the source of the icon pointing to Ardour miscelaneous resources repository directory.

[PeterShaggyNoble]

Thanks for taking the time to reply and provide us with that file, @thorwil - we very much appreciate it.

The height of your SVG is a little off, @mondeja (20.933 vs. the expected 20.787), leading to the sort of differences seen below, with your version in red. With a vector of the newest logo seemingly not being available anywhere I'm not sure about the source URL but I think what you've used is a good compromise; hopefully by the time they next update their logo, that repo will be up to date.

[mondeja]

Resized to 20.787. Let me know if you catch another inconvenient.

[PeterShaggyNoble]

You've gone the other way now, @mondeja - this is now coming in at only 23.832 in width.

[PeterShaggyNoble]

Took me a second to realise that you based your latest version on the more simplified second icon in the provided zip! 🤦‍♂️ Yours lines up perfectly with that and, for our purposes, I'm OK with using that second icon.

I'll let @thorwil have the final, official say, though; if they give the 👍 on us using the second icon over the first then this is ready to merge.

[thorwil]

That version is really only meant for 48px and maybe below. For anything larger,
ardour.zip would be better. So it depends on what kind of use you expect.

[PeterShaggyNoble]

As our native size is 24*24, I think that suits us perfectly, so.

Thanks for your efforts on this one, @mondeja and for your valuable inpu & feedback, @thorwil.