Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QT icon #2955

Closed
wants to merge 1 commit into from
Closed

Add QT icon #2955

wants to merge 1 commit into from

Conversation

luckyf
Copy link
Contributor

@luckyf luckyf commented Apr 18, 2020

qt

Issue: Closes #2947

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Name: QT
Website: QT.io
Alexa Rank: ~17.1k
Official resources for icon and color: Logo
Color: #41CD52

The changes in line 1944-1946 of simple_icons.json are just for alignment.

@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Apr 19, 2020
@PeterShaggyNoble
Copy link
Member

PeterShaggyNoble commented Apr 20, 2020

Thanks once again for the PR, @luckyf.

You seem to be picking up a few of the trickier ones lately 🙈 I'm using the Print/Qt Logo/qt_logo_green_PANTONE_802.ai for comparison and seeing some hairline differences around the inside of the letters but, again, that could be down to a difference in sources - which file did you base your SVG on?

Also, two other minor things:

  1. Firstly, and purely from the point of view of my own personal preference, I'd drop the #logos from the source URL, and,
  2. Secondly, and more importantly, the name should be stylised as "Qt", rather than "QT". Although, to avoid any potential future clashes in names, we could use the full name of "The Qt Company".

@PeterShaggyNoble PeterShaggyNoble added awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed changes requested labels Apr 20, 2020
@ericcornelissen
Copy link
Contributor

Just chiming in here to say that I agree with both minor comments by @PeterShaggyNoble

@hatem-u
Copy link

hatem-u commented May 10, 2020

Any progress on this one yet?

@ericcornelissen
Copy link
Contributor

@luckyf are you planning to continue working on this in the near future?

@hatemU, if @luckyf cannot continue their contribution, would you be interested in opening a Pull Request for QT?

@hatem-u
Copy link

hatem-u commented May 12, 2020

@ericcornelissen I would love to contribute, but I have no experience in this field.

@ericcornelissen
Copy link
Contributor

@hatemU you can have a look at our contributing guidelines for more information, and you are free to use this Pull Request as a starting point.

If you do decide to work on this, let everyone know in this thread 🙂

@PeterShaggyNoble
Copy link
Member

@hatemU, would you still like to give this one a try?

@ericcornelissen
Copy link
Contributor

I will close this PR for now to give other a chance to contribute the icon.

@luckyf if you want to continue your contribution (and QT hasn't been added yet) feel free to let us know here

@ericcornelissen ericcornelissen removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Jun 3, 2020
@PeterShaggyNoble
Copy link
Member

I'll take this one; need something quick & easy to warm my brain up on this morning.

@PeterShaggyNoble PeterShaggyNoble mentioned this pull request Jun 4, 2020
3 tasks
@PeterShaggyNoble PeterShaggyNoble added the abandoned Pull requests that have been abandoned by the contributor label Jun 4, 2020
@luckyf luckyf deleted the qt branch July 12, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned Pull requests that have been abandoned by the contributor new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Qt Icon
5 participants