Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rancher (#3034) #3035

Merged
merged 3 commits into from
May 12, 2020
Merged

Conversation

kshitishp
Copy link
Contributor

@kshitishp kshitishp commented May 6, 2020

Rancher

Issue: Closes #3034

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

All hex values, vectors and other brand requirements taken from https://rancher.com/brand-guidelines/

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label May 6, 2020
@PeterShaggyNoble PeterShaggyNoble changed the title 3034 rancher Add Rancher (#3034) May 6, 2020
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @kshitishp.

Two small things before this can be merged in though:

  1. You can remove the registered trademark symbol. Unless a company explicitly & irrevocably requires its inclusion or its an integral part of the design, we generally omit them.
  2. You'll need to remove the CloudStack JSON entry and SVG from your branch.

@kshitishp
Copy link
Contributor Author

  1. You can remove the registered trademark symbol. Unless a company explicitly & irrevocably requires its inclusion or its an integral part of the design, we generally omit them.

I checked up #2460 and felt this icon falls most appropriately under point 5 (There is an explicit requirement that the symbol be included) - though there is a guideline that the ® should be included if/when the copy contains certain labels (https://rancher.com/brand-guidelines/). Do I take it as this creating ambiguity and making this fall under point 3 (There is an explicit requirement that the symbol be included but there is ambiguity about under which conditions it may be removed)?

  1. You'll need to remove the CloudStack JSON entry and SVG from your branch.

Oops :) Rookie mistake!

@PeterShaggyNoble
Copy link
Member

Ah! I was looking for guidance on the trademark symbol in the wrong place; under what not to do with the logo. I see it now under what to do.

Use the cow (with ®)

That certainly suggests that it should be included but not necessarily that it must be included. I was looking at the "Don't"s, looking for something that explicitly stated not to remove it. So, yeah, there is a wee bit of ambiguity there, which from #2460 would mean we should include it. Although that issue is still in discussion.

My other concern now is the rest of that point:

... if the Rancher Labs, RancherOS, Rancher is visible in copy

That suggests that the cow should only be used on its own if the company name is mentioned in the copy of the page it's being displayed on, which would mean we'd need to include the wordmark (but could omit the symbol). But, again, it's ambiguous so I'd say we can get away without including it.

Let's see how the other @simple-icons/maintainers feel.

@PeterShaggyNoble PeterShaggyNoble added the in discussion There is an ongoing discussion that should be finished before we can continue label May 6, 2020
@kshitishp
Copy link
Contributor Author

End of the day, it's an icon, right? So it shouldn't be an issue as such. The ®, at those small sizes, only makes stuff rather unreadable. I don't see a lot of brands covering glyphs in their brand guidelines - so it's ambiguous, to say the least, and it should be ok to not include the mark.

I'll wait for the maintainers before pushing another commit.

@runxel
Copy link
Member

runxel commented May 6, 2020

Chiming in on that topic:
I'm in favor of using the cow alone, but, and I sadly have to agree, we are in need to include the ®️ then...
Even tho #2460 is not finally settled: If a company is stupid enough to brace their demand of including a tautological boilerplate and smudging the icon, we can't deter it. 😃

@ericcornelissen
Copy link
Contributor

I'd agree as well that it is better to include the (R) symbol in this case

@kshitishp
Copy link
Contributor Author

  1. You can remove the registered trademark symbol. Unless a company explicitly & irrevocably requires its inclusion or its an integral part of the design, we generally omit them.

I've left the symbol as it is based on the comments here.

  1. You'll need to remove the CloudStack JSON entry and SVG from your branch.

I had created the new branch from the wrong base. I've rebased and updated the PR. I hope I haven't messed it up further 🙈

@PeterShaggyNoble PeterShaggyNoble removed the in discussion There is an ongoing discussion that should be finished before we can continue label May 7, 2020
@PeterShaggyNoble
Copy link
Member

Dang! Overruled again! 😆

@kshitishp, can you update the SVG to centre the path vertically on the canvas? Once that's done, this should be good to go.

@kshitishp
Copy link
Contributor Author

Dang! Overruled again! 😆

@kshitishp, can you update the SVG to centre the path vertically on the canvas? Once that's done, this should be good to go.

Done. It was again a matter of second decimals :|

@PeterShaggyNoble
Copy link
Member

Thanks for your efforts on this one, @kshitishp - everything looks perfect now 👍 (Except, of course, for the inclusion of the trademark symbol at all 😆)

@PeterShaggyNoble PeterShaggyNoble merged commit d0b2ff6 into simple-icons:develop May 12, 2020
ericcornelissen added a commit that referenced this pull request May 17, 2020
# New Icons

- Rancher (#3035)

# Updated Icons

- Adobe Creative Cloud (#3032)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Rancher icon
4 participants