-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rancher (#3034) #3035
Add Rancher (#3034) #3035
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, @kshitishp.
Two small things before this can be merged in though:
- You can remove the registered trademark symbol. Unless a company explicitly & irrevocably requires its inclusion or its an integral part of the design, we generally omit them.
- You'll need to remove the CloudStack JSON entry and SVG from your branch.
I checked up #2460 and felt this icon falls most appropriately under point 5 (There is an explicit requirement that the symbol be included) - though there is a guideline that the ® should be included if/when the copy contains certain labels (https://rancher.com/brand-guidelines/). Do I take it as this creating ambiguity and making this fall under point 3 (There is an explicit requirement that the symbol be included but there is ambiguity about under which conditions it may be removed)?
Oops :) Rookie mistake! |
Ah! I was looking for guidance on the trademark symbol in the wrong place; under what not to do with the logo. I see it now under what to do.
That certainly suggests that it should be included but not necessarily that it must be included. I was looking at the "Don't"s, looking for something that explicitly stated not to remove it. So, yeah, there is a wee bit of ambiguity there, which from #2460 would mean we should include it. Although that issue is still in discussion. My other concern now is the rest of that point:
That suggests that the cow should only be used on its own if the company name is mentioned in the copy of the page it's being displayed on, which would mean we'd need to include the wordmark (but could omit the symbol). But, again, it's ambiguous so I'd say we can get away without including it. Let's see how the other @simple-icons/maintainers feel. |
End of the day, it's an icon, right? So it shouldn't be an issue as such. The ®, at those small sizes, only makes stuff rather unreadable. I don't see a lot of brands covering glyphs in their brand guidelines - so it's ambiguous, to say the least, and it should be ok to not include the mark. I'll wait for the maintainers before pushing another commit. |
Chiming in on that topic: |
I'd agree as well that it is better to include the (R) symbol in this case |
I've left the symbol as it is based on the comments here.
I had created the new branch from the wrong base. I've rebased and updated the PR. I hope I haven't messed it up further 🙈 |
Dang! Overruled again! 😆 @kshitishp, can you update the SVG to centre the path vertically on the canvas? Once that's done, this should be good to go. |
Done. It was again a matter of second decimals :| |
Thanks for your efforts on this one, @kshitishp - everything looks perfect now 👍 (Except, of course, for the inclusion of the trademark symbol at all 😆) |
Issue: Closes #3034
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
All hex values, vectors and other brand requirements taken from https://rancher.com/brand-guidelines/