Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'wslint' command that isn't linting the simple-icons.json file. #3079

Merged
merged 2 commits into from May 14, 2020
Merged

Fix 'wslint' command that isn't linting the simple-icons.json file. #3079

merged 2 commits into from May 14, 2020

Conversation

mondeja
Copy link
Member

@mondeja mondeja commented May 13, 2020

Seems that editorconfig-checker -exclude parameter accepts regular expressions instead of globs. Also, I've revert the change on .editorconfig file and added a final newline to the JSON. That will resolve the inconsistencies.

@ericcornelissen

This comment has been minimized.

@ericcornelissen ericcornelissen added meta Issues or pull requests regarding the project or repository itself in discussion There is an ongoing discussion that should be finished before we can continue labels May 13, 2020
@runxel

This comment has been minimized.

@mondeja

This comment has been minimized.

@mondeja

This comment has been minimized.

@ericcornelissen

This comment has been minimized.

@mondeja
Copy link
Member Author

mondeja commented May 14, 2020

If you could investigate that, that would be very helpful.

I've added a commit that fix this. Seems that editorconfig-checker -exclude parameter accepts regular expressions instead of globs. Also, I've revert the change on .editorconfig file and added a final newline to the JSON. That will resolve the inconsistencies.

@mondeja mondeja changed the title Avoid insert final newline in simple-icons.json for .editorconfig Fix 'wslint' command that isn't linting the simple-icons.json file. May 14, 2020
Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a commit that fix this. Also, I've revert the change on .editorconfig file and added a final newline to the JSON. That will resolve the inconsistencies.

Thanks and thanks! 🎉

Seems that editorconfig-checker -exclude parameter accepts regular expressions instead of globs.

Can't believe we didn't realize that at the time and have been using it incorrectly for all that time... 😅

@ericcornelissen ericcornelissen removed the in discussion There is an ongoing discussion that should be finished before we can continue label May 14, 2020
@ericcornelissen ericcornelissen merged commit 1f9fe88 into simple-icons:develop May 14, 2020
@PeterShaggyNoble
Copy link
Member

PeterShaggyNoble commented May 26, 2020

This seems to have broken something in our linting process:

  • This build is failing because there is a trailing newline in simple-icons.json.
  • While this one is failing because there isn't.

@ericcornelissen
Copy link
Contributor

Seems to be related to #3112? Note that the two build fails because of different reasons, though I agree that the error message is not very clear (but that is a problem that should be solved at the linter's end)

It's quite unfortunate that this change is not being reflected in a lot of older Pull Requests, causing some annoying failing builds in newer Pull Requests and even on the develop branch itself 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues or pull requests regarding the project or repository itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants