New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 'wslint' command that isn't linting the simple-icons.json file. #3079
Fix 'wslint' command that isn't linting the simple-icons.json file. #3079
Conversation
…fig for '.editorconfig'.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
….editorconfig configuration.
I've added a commit that fix this. Seems that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a commit that fix this. Also, I've revert the change on .editorconfig file and added a final newline to the JSON. That will resolve the inconsistencies.
Thanks and thanks! 🎉
Seems that editorconfig-checker -exclude parameter accepts regular expressions instead of globs.
Can't believe we didn't realize that at the time and have been using it incorrectly for all that time... 😅
This seems to have broken something in our linting process:
|
Seems to be related to #3112? Note that the two build fails because of different reasons, though I agree that the error message is not very clear (but that is a problem that should be solved at the linter's end) It's quite unfortunate that this change is not being reflected in a lot of older Pull Requests, causing some annoying failing builds in newer Pull Requests and even on the |
Seems that
editorconfig-checker
-exclude
parameter accepts regular expressions instead of globs. Also, I've revert the change on.editorconfig
file and added a final newline to the JSON. That will resolve the inconsistencies.