New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Google Play Music #3126
Add Google Play Music #3126
Conversation
Thanks for the contribution, @NovaGL 👍 If they're only discontinuing the music service and not the app then I think we're OK to add this. If however, they're discontinuing both I don't see much point in adding it just to remove it again in a few weeks/months, unless they have a pretty lengthy roadmap to discontinuation. Don't have time right now to do a full review of the SVG but that treatment looks great to me, nice work.
|
My understanding is they are changing the service side of things (online). Meaning Google Play Music will still be used as the app for your local music but anything related to online will be moved to YouTube Music. It would be odd to call an offline music player YouTube Music. |
I would be surprised if they get rid Google Play Music entirely, especially in a few weeks or months 🤔 I think we can include it for now, unless there is a definitive source indicating that Google Play Music will be discontinued in the near future (which this article arguably is, but to me it seems that Google Play Music will still be around around our v4 release). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I can't find anything to say the app is being discontinued and the only timeline I can find is "later in 2020" so I think we can go ahead and add this. Even if they are discontinuing the app, it's not like everyone's going to immediately uninstall it from their devices.
Couple of things before we an merge this, though, @NovaGL:
- From the SVG I posted above, I'd suggest we go with the more vibrant
#f4481e
for the colour. - Your SVG is coming in at just
23
high, can you scale that up to24
? - After scaling it up, there are a few differences between your version (in black below) and the one I provided.
If you based your icon on one available from this page, though, can you let us know and we'll compare to that instead? Probably just me being blind again, but I don't see any vector files available for download there.
I've done those changes as requested. Sorry for all the commits, I'm just using the web browser for commits so don't know how to stage and then push them all at once. For some reason the bottom looks worse on this version however it looks perfect in Illustrator. |
Thanks for the update, @NovaGL However, the SVG is coming in at |
Thanks Peter. Weird about the height. It seems this logo is not as easy as I first thought. Looks like it might take me a few more attempts. I'll let you know. |
I took a quick stab at it myself, if it's any help to you. I went with a slightly thicker cut-out as it looks better at smaller sizes. But not as good at bigger sizes.
|
Looks good to me. I'm happy to go with that. |
Me, either, and ...
Me too! I gets a bit easier with practice, though. I'm still not entirely happy with the cut-out on mine; I think we lose too much of the filled circle. |
I think you might be being a bit hard on yourself. This logo is not really meant for monochrome so it's gonna be hard for anyone |
Gave it another try with different sized cut-outs; the one above was 1px, the first one below is .5px and the second one is .75px. Trying to strike a balance between the cut-out being visible and not losing too much of the circle so I think .75 might be the way to go. What do the other @simple-icons/maintainers think? |
I'd say both |
I personally like |
Here's the unoptimised path data for that one, if you want to use it as a starting point, @NovaGL
And, to help you with your future contributions or if you'd like to try to recreate what I did, here's a quick step-by-step:
|
Thanks for the update, @NovaGL, looks good to me now (but I would say that! 😆) A couple of minor things to fix:
|
Hopefully this is good now. If not I might need you to look into it @PeterShaggyNoble It seems to not like my PC and I couldn't even see those small dots unless I reloaded your path. |
Nice work, @NovaGL I'm noticing a couple of hairline differences around the edges between your version and mine, though. As this is an original interpretation of the logo, it's not the end of the world, but could you try a precision of 4 'til we see how that looks? |
Issue: Closes #3124
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
I had to manually modify the icon as it's not available in monochrome.
SVG Source: https://commons.wikimedia.org/wiki/File:Google_Play_Music_icon_(2016).svg