Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TypeScript #3400

Closed
wants to merge 3 commits into from
Closed

Update TypeScript #3400

wants to merge 3 commits into from

Conversation

adamalston
Copy link
Contributor

@adamalston adamalston commented Aug 1, 2020 •
edited
Loading

Update TypeScript

typescript

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

I have updated the TypeScript hex and source to reflect brand changes that have taken affect. Those changes are highlighted in the TypeScript Website Roadmap.

The old source pointed to a GitHub repository with an unofficial logo. The new source is the official TypeScript brand website. On this website, the official logo and colors are displayed.

@adamalston adamalston changed the title update typescript hex and source Update TypeScript Aug 1, 2020
@ericcornelissen ericcornelissen added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Aug 1, 2020
@runxel
Copy link
Member

runxel commented Aug 1, 2020

Thanks for this PR, @adamalston!
However it seems they indeed also changed logo. Not by much, but it's still outdated. (Easily identified by the "S")

Would you also take care of updating the svg? :)

@runxel runxel added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Aug 1, 2020
@adamalston
Copy link
Contributor Author

adamalston commented Aug 2, 2020 •
edited
Loading

Done @runxel!

Added new icon preview above.

@runxel runxel removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Aug 2, 2020
@runxel
Copy link
Member

runxel commented Aug 3, 2020

Hey @adamalston, thank you so much!
Looking good, but I have one request:
It seems you based your version on the "512" variant of TS. Given that we assume our users use the logos at very small sizes (after all we save the icons on a 24×24 square) I'd rather expect to have the icon based on the "128" version.
Those three version of logo sizes differ quite heavily (which I didn't figured out earlier)!
Before you do unnecessary work, I will ring for another @simple-icons/maintainers.

@adamalston
Copy link
Contributor Author

Updated logo to 128x with new preview above @runxel.

runxel
runxel requested changes Sep 25, 2020
View reviewed changes
Copy link
Member

@runxel runxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adamalston!
But what happened to the S?
The OG is smooth and round, but yours is all wrinkled up...
Maybe check that again :)

@fbernhart
Copy link
Contributor

Just to no forget about this PR:

Are you still working on this one @adamalston?

@fbernhart fbernhart added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Dec 15, 2020
@adamalston
Copy link
Contributor Author

adamalston commented Dec 15, 2020 •
edited
Loading

If someone else wants to take it on and submit an update, feel free!

I haven't had the time to properly take a look at it. @fbernhart

@mondeja mondeja added help wanted and removed awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed labels Dec 16, 2020
@fbernhart fbernhart mentioned this pull request Dec 16, 2020
Merged
3 tasks
@fbernhart
Copy link
Contributor

Closing this as I've opened a new PR (#4370) to update the icon.

@fbernhart fbernhart closed this Dec 16, 2020
@mondeja mondeja added abandoned Pull requests that have been abandoned by the contributor and removed changes requested labels Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runxel runxel runxel requested changes

Assignees
No one assigned
Labels
abandoned Pull requests that have been abandoned by the contributor update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@adamalston @runxel @fbernhart @ericcornelissen @mondeja