Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Max-Planck-Gesellschaft Icon #3793

Merged
merged 6 commits into from
Dec 20, 2020
Merged

Add Max-Planck-Gesellschaft Icon #3793

merged 6 commits into from
Dec 20, 2020

Conversation

fbernhart
Copy link
Contributor

@fbernhart fbernhart commented Nov 1, 2020 •
edited by service-paradis

maxplanckgesellschaft

Close #3787
Alexa rank: 29,904

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Nov 1, 2020
@kalaschnik
Copy link

@fbernhart ; Why were you not using the #7367 as suggested by the official Pantone website for hex: https://store.pantone.com/de/de/colorfinder/index/acfproduct/code/328+C?
Your color (#007D7A) is not as close as (#7367) to Pantone 328C.

@fbernhart
Copy link
Contributor Author

@kalaschnik Thanks for your input! :) I've actually just used the color that was already used in the .svg file from Wikimedia - from the link that you've provided in your issue (#3793). This color has the hex value #7367.

Now I've just checked their website and the header and footer are using the color #006C66.

I've googled a bit and found an official style guide for their logo: https://www.mpikg.mpg.de/6335559/Logo-Guide-Print-_-Max-Planck-Gesellschaft.pdf

On page 6 it mentions as well the color: #006C66

So I think it will be the best to stick to #006C66. I'll add a commit to change it right now.

@kalaschnik
Copy link

Thank you so much for investigating! Seems best to go for #006C6 then!

@adamrusted
Copy link
Member

adamrusted commented Dec 20, 2020 •
edited

There's an SVG embedded in the homepage - would we be better to reference that as a source than Wikipedia? If so, there's a fair few differences between the versions of the logo - red being the path proposed in the PR, and black being the SVG found on the homepage.

Capture

@adamrusted adamrusted added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Dec 20, 2020
@fbernhart
Copy link
Contributor Author

@adamrusted Thanks for pointing this out! This has actually been my first PR for simple-icons.

No wonder, that I've missed this 😄

@adamrusted adamrusted removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Dec 20, 2020
@fbernhart
Copy link
Contributor Author

@adamrusted Should be fine now. Please check again and feel free to merge it, if it's ok. 😊

adamrusted
adamrusted approved these changes Dec 20, 2020
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@adamrusted adamrusted merged commit 7d4b2de into simple-icons:develop Dec 20, 2020
@fbernhart fbernhart deleted the add_max_planck branch December 20, 2020 18:02
@kalaschnik
Copy link

@adamrusted, how long does it take after a merged PR, that the icon appears on simpleicons.org / is usable?

@adamrusted
Copy link
Member

@adamrusted, how long does it take after a merged PR, that the icon appears on simpleicons.org / is usable?

So the new icon are added to the 'develop' branch, which is automatically released once a week on a Sunday. Unfortunately we just missed the last release - but does mean it should be included at the end of this week!

@kalaschnik
Copy link

Thanks for the info.

@github-actions github-actions bot mentioned this pull request Dec 27, 2020
Merged
ericcornelissen added a commit that referenced this pull request Dec 27, 2020
@ericcornelissen
Release 19 new icons and 110 updated icons (v4.4.0)
c129d2a 
# New Icons

- Apache Tomcat (#4154)
- Blazemeter (#4385)
- Cocos (#4340)
- Delphi (#4139)
- DoorDash (#4094)
- GitBook (#3975)
- Informatica (#4142)
- Jaguar (#4267)
- Max-Planck-Gesellschaft (#3793)
- MeWe (#4268)
- ngrok (#3949)
- Packagist (#4390)
- PCGamingWiki (#3664)
- Pro Tools (#3880)
- SingleStore (#4451)
- Spyder IDE (#4092)
- Thymeleaf (#4411)
- Triller (#4384)
- TryHackMe (#4258)

# Updated Icons

- Academia (#4449)
- Adobe InDesign (#4460)
- AirPlay Audio (#3963)
- Amazon Lumberyard (#3964)
- AngelList (#3966)
- Apache NetBeans IDE (#4421)
- Apple Pay (#3972)
- AT&T (#3980)
- AT&T (#3980)
- Azure Functions (#3983)
- Baidu (#3984)
- Beats (#3995)
- Beats by Dre (#3996)
- Behance (#3997)
- Boeing (#4000)
- Buffer (#4004)
- CD Projekt (#4432)
- Cinema 4D (#4005)
- Cirrus CI (#4006)
- CloudBees (#4007)
- CodeChef (#4009)
- CodeIgniter (#4010)
- Codeship (#4011)
- Codewars (#4012)
- Common Workflow Language (#4013)
- ComproPago (#4015)
- Corona Engine (#4454)
- Craft CMS (#4144)
- CSS Wizardry (#4017)
- Dassault Systèmes (#4019)
- DataCamp (#4455)
- Datadog (#4020)
- dblp (#4021)
- Diaspora (#4023)
- DLNA (#4025)
- Draugiem.lv (#4026)
- Elastic Cloud (#4031)
- Electron (#4034)
- Elixir (#4035)
- Envato (#4038)
- Eventbrite (#4039)
- Ferrari N.V. (#4456)
- FileZilla (#4048)
- freedesktop.org (#4049)
- Garmin (#4445)
- Genius (#4050)
- Gitea (#4052)
- GitHub Sponsors (#4457)
- Gitpod (#4441)
- Glitch (#4053)
- GNU IceCat (#4054)
- GoldenLine (#4056)
- Goodreads (#4057)
- Google Nearby (#4059)
- Grafana (#4062)
- Gumtree (#4064)
- HackerEarth (#4065)
- Haskell (#4066)
- Helm (#4067)
- HERE (#4068)
- Hexo (#4069)
- homify (#4070)
- iCloud (#4073)
- ICON (#4074)
- ICQ (#4075)
- Indeed (#4076)
- JetBrains (#4347)
- Jinja (#4078)
- KaiOS (#4079)
- Kentico (#4080)
- Keybase (#4081)
- Kibana (#4082)
- Last.fm (#4083)
- LeetCode (#4084)
- LibraryThing (#4085)
- LLVM (#4088)
- Mendeley (#4102)
- Mix (#3921)
- Mojang Studios (#4288)
- Notist (#4112)
- Nutanix (#4114)
- Opel (#4431)
- Open Collective (#4160)
- Overleaf (#4162)
- Palo Alto Software (#4163)
- Pi-hole (#4167)
- Prismic (#4171)
- protocols.io (#4172)
- ProtonMail (#4173)
- PureScript (#4174)
- Quarkus (#4175)
- React (#4430)
- Realm (#3930)
- Scrutinizer CI (#3935)
- Slackware (#3938)
- StackPath (#4198)
- Topcoder (#4226)
- Tor Project (#4248)
- TrainerRoad (#4227)
- Treehouse (#4228)
- Udacity (#4229)
- Vagrant (#4230)
- Veeam (#4231)
- Wattpad (#4290)
- webcomponents.org (#4234)
- WeChat (#4236)
- Windows 95 (#4237)
- XAML (#4240)
- Yelp (#4242)
- Zulip (#4255)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrusted adamrusted adamrusted approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: Max Planck Society Icon
3 participants
@fbernhart @kalaschnik @adamrusted