New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Koding #3912
Remove Koding #3912
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fbernhart, can you remove the icon in this pull as has been discussed in #4129, so in v5 v6 release we need only to merge this pull?
This comment has been minimized.
This comment has been minimized.
Labelling this as pending the outcome of #4735. |
OK, looks like we have a consensus on a secondary cut-off of 750k for brands that have already been added, allowing us to keep this one based on its current rank of ~630k. However, as there has been no activity in the blog, on their social media or in their GitHub repos for years and their primary repo has been archived, I think we're safe enough to make a judgement call that this is no longer a going concern and can be removed. This is aided by the precedent being set by the removal of Vine earlier today, which had a much healthier rank. If we do decide to keep it then the icon and colour will need to be updated. |
I'd be inclined to say we should remove this as the hosted service has been discontinued (ref 1, ref 2) and the open source project has been archived. On the other hand, as the Alexa rank is still okay-ish, at least in the context of #4735, we should maybe just keep it for one more release - there's no real harm in that either. My vote would be to keep it for now, we can consider it a trail for #4735 🙃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I agree that this should be removed due to the repo being archived, and their services being shut down, the fact that the Alexa rank is still relatively high would suggest it's still popular. Think waiting until v6 is our best bet.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following #5775, I'm actually not sure if we should merge this given that the Alexa rank of koding.com
is still at ~540k.
It does seem the icon needs to be updated if we decide to keep it.
Considering the repo is archived and our icon is outdated, I think it should just be removed. |
This raiaes a good question: is Simple Icons a library of only currently extant icons? Just because a brand doesn't exist anymore, does that means that the brand is no longer relevant in any way for users? For example, my personal case: if the applications I've made that use certain technologies' icons are updated to the latest version, am I in danger of errors because a popular technology I used a while back is no longer actively developed? I think this should be removed, but the SVG file should be frozen elsewhere for direct download, at least. |
I think you have a very valid point @jorgeamadosoria. But I don't think we should keep such icons in the main package. I think it'd be great if we could publish these "deprecated, but still used" icons in separate packages ( |
I think we should only keep existing icon as part of the active release. If someone really want to use a deprecated icon, they can still use an old version of Simple Icons. For example, HipChat have been removed in the latest release (v5). So, we're not able to get it using the current package (https://cdn.jsdelivr.net/npm/simple-icons@v5/icons/hipchat.svg), but we still can use it using the v4 (https://cdn.jsdelivr.net/npm/simple-icons@v4/icons/hipchat.svg). |
I agree @sachinraja , that's my point. A separate repoaitory without all the bells and whistles of the main repo. Maybe not even a repository. Maybe a discontinued page in the web side would be enough. |
That's not a sufficient solution, however. Old icons shouldn't be in the main repo, but they should be somewhere. Even if only as a svg file to be downloaded |
I'm inclined to move this removal to v7 because the Alexa Rank has not been fallen enough.
You can download old icons using the CDN link format that @service-paradis has shared https://cdn.jsdelivr.net/npm/simple-icons@v4/icons/hipchat.svg |
I'm unfamiliar with the brand, but it could just be that they moved to closed source.
While it's fine to have that discussion, as of this Pull Request this is an established process. Approximately every 6 months there's a major release that removes SVGs of brands that no longer exist as well as SVGs for brands that are not popular enough anymore. If anyone wants to change that, it's best to have a discussion about that separate from this Pull Request. If there's consensus amongst @simple-icons/maintainers that we should discuss it prior to releasing v6 than that consensus should be reached soon as that release is currently planned for November 28, 2021. |
If you go to the login page, it tells you that the hosted version has been discontinued and you can only self-host now. But the self-hosted version is just the https://github.com/koding/koding repo, which is archived. None of the repos in the koding org show any activity, so I think it's safe to say the brand no longer exists. |
this has nothing to do with the v6 release. Like I said, the icon can be removed regardless. The problem is to keep it accesible in some way. |
this is good enough as hosting, but where is the discovery part? How is any end user suppose to know that exists? |
I agree. A note could be added in CDN usage section of README, deprecated section of VERSIONING.md or even in both sides. Do you want to open an PR for that @jorgeamadosoria? |
Given that, I'm not against to include this removal in v6 👍🏼 |
I opened a ticket on the website to add a page with the links to the website. I don't know if you think I should add a page there, or just an .md document with a list of discontinued icons in the documentation for the main repo. |
# New Icons - Chromecast (#6901) - Game & Watch (#6876) - Lerna (#5524) - MUI (#6730) - QuickLook (#6874) - Salt Project (#6897) - The Algorithms (#6917) # Updated Icons - BandLab (#6887) - Deno (#6771) # Removed Icons - Fedora (#6892) - Google Cast (#6901) - Koding (#3912) - Material-UI (#6902) - PJSIP (#4910) - SaltStack (#6891) - Skyliner (#6890)
Issue: #3169
Alexa rank: -
Checklist
_data/simple-icons.json
--> (wasn't necessary)viewbox
is0 0 24 24
Description
I took the already used SVG.I used Inkscape to fix size and center
I used https://jakearchibald.github.io/svgomg/ to optimize the resulting SVG
This PR is removing the Koding icon as per the discussion in #4129