Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Koding #3912

Merged
merged 4 commits into from Nov 24, 2021
Merged

Conversation

fbernhart
Copy link
Contributor

@fbernhart fbernhart commented Nov 18, 2020

koding

Issue: #3169
Alexa rank: -

Checklist

  • I updated the JSON data in _data/simple-icons.json --> (wasn't necessary)
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

I took the already used SVG.
I used Inkscape to fix size and center
I used https://jakearchibald.github.io/svgomg/ to optimize the resulting SVG

This PR is removing the Koding icon as per the discussion in #4129

@github-actions github-actions bot added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Nov 18, 2020
@service-paradis

This comment has been minimized.

Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fbernhart, can you remove the icon in this pull as has been discussed in #4129, so in v5 v6 release we need only to merge this pull?

@fbernhart

This comment has been minimized.

@fbernhart fbernhart changed the title Updated Koding Remove Koding Dec 11, 2020
@fbernhart fbernhart added breaking change Issues or pull requests that include a breaking change and scheduled for the next major release out of scope Issues or pull requests that are beyond the scope of the project and removed update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both labels Dec 11, 2020
@mondeja mondeja added this to the v5.0.0 milestone Dec 11, 2020
@service-paradis service-paradis linked an issue Dec 11, 2020 that may be closed by this pull request
@ericcornelissen ericcornelissen marked this pull request as draft December 16, 2020 09:04
@ericcornelissen ericcornelissen marked this pull request as ready for review May 23, 2021 18:09
@PeterShaggyNoble PeterShaggyNoble added the pending Issues that are pending because of e.g. a scheduled brand update label May 24, 2021
@PeterShaggyNoble
Copy link
Member

Labelling this as pending the outcome of #4735.

@PeterShaggyNoble
Copy link
Member

OK, looks like we have a consensus on a secondary cut-off of 750k for brands that have already been added, allowing us to keep this one based on its current rank of ~630k.

However, as there has been no activity in the blog, on their social media or in their GitHub repos for years and their primary repo has been archived, I think we're safe enough to make a judgement call that this is no longer a going concern and can be removed. This is aided by the precedent being set by the removal of Vine earlier today, which had a much healthier rank.

If we do decide to keep it then the icon and colour will need to be updated.

@PeterShaggyNoble PeterShaggyNoble added in discussion There is an ongoing discussion that should be finished before we can continue and removed pending Issues that are pending because of e.g. a scheduled brand update labels May 24, 2021
@ericcornelissen
Copy link
Contributor

ericcornelissen commented May 25, 2021

I'd be inclined to say we should remove this as the hosted service has been discontinued (ref 1, ref 2) and the open source project has been archived. On the other hand, as the Alexa rank is still okay-ish, at least in the context of #4735, we should maybe just keep it for one more release - there's no real harm in that either.

My vote would be to keep it for now, we can consider it a trail for #4735 🙃

@PeterShaggyNoble PeterShaggyNoble modified the milestones: v5.0.0, v6.0.0 May 26, 2021
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I agree that this should be removed due to the repo being archived, and their services being shut down, the fact that the Alexa rank is still relatively high would suggest it's still popular. Think waiting until v6 is our best bet.

@ericcornelissen ericcornelissen marked this pull request as draft May 26, 2021 19:59
@ericcornelissen ericcornelissen removed the in discussion There is an ongoing discussion that should be finished before we can continue label May 26, 2021
@ericcornelissen ericcornelissen marked this pull request as ready for review November 22, 2021 19:38
@ericcornelissen

This comment has been minimized.

@ericcornelissen ericcornelissen added the in discussion There is an ongoing discussion that should be finished before we can continue label Nov 22, 2021
Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following #5775, I'm actually not sure if we should merge this given that the Alexa rank of koding.com is still at ~540k.

It does seem the icon needs to be updated if we decide to keep it.

@sachinraja
Copy link
Contributor

Considering the repo is archived and our icon is outdated, I think it should just be removed.

@jorgeamadosoria
Copy link
Contributor

This raiaes a good question: is Simple Icons a library of only currently extant icons? Just because a brand doesn't exist anymore, does that means that the brand is no longer relevant in any way for users?

For example, my personal case: if the applications I've made that use certain technologies' icons are updated to the latest version, am I in danger of errors because a popular technology I used a while back is no longer actively developed?

I think this should be removed, but the SVG file should be frozen elsewhere for direct download, at least.
The icon should remain accesible to users in some form to reduce backward compatibility issues, specially in cases like this where the brand may be out, but its popularity is still strong

@sachinraja
Copy link
Contributor

I think you have a very valid point @jorgeamadosoria. But I don't think we should keep such icons in the main package. I think it'd be great if we could publish these "deprecated, but still used" icons in separate packages (@simple-icons/deprecated-icon) instead of in the main package.

@service-paradis
Copy link
Member

I think we should only keep existing icon as part of the active release. If someone really want to use a deprecated icon, they can still use an old version of Simple Icons.

For example, HipChat have been removed in the latest release (v5). So, we're not able to get it using the current package (https://cdn.jsdelivr.net/npm/simple-icons@v5/icons/hipchat.svg), but we still can use it using the v4 (https://cdn.jsdelivr.net/npm/simple-icons@v4/icons/hipchat.svg).

@jorgeamadosoria
Copy link
Contributor

jorgeamadosoria commented Nov 23, 2021

I agree @sachinraja , that's my point. A separate repoaitory without all the bells and whistles of the main repo.

Maybe not even a repository. Maybe a discontinued page in the web side would be enough.
The point is that the user can't find themself in a situation where an icon vanishes from one version to the other without fallback or options to keep their web or app looking as before

@jorgeamadosoria
Copy link
Contributor

I think we should only keep existing icon as part of the active release. If someone really want to use a deprecated icon, they can still use an old version of Simple Icons.

For example, HipChat have been removed in the latest release (v5). So, we're not able to get it using the current package (https://cdn.jsdelivr.net/npm/simple-icons@v5/icons/hipchat.svg), but we still can use it using the v4 (https://cdn.jsdelivr.net/npm/simple-icons@v4/icons/hipchat.svg).

That's not a sufficient solution, however.
It would mean that I need to eother use two versions of the library or be stuck with an old version.

Old icons shouldn't be in the main repo, but they should be somewhere. Even if only as a svg file to be downloaded

@mondeja
Copy link
Member

mondeja commented Nov 23, 2021

I'm inclined to move this removal to v7 because the Alexa Rank has not been fallen enough.

Old icons shouldn't be in the main repo, but they should be somewhere. Even if only as a svg file to be downloaded

You can download old icons using the CDN link format that @service-paradis has shared https://cdn.jsdelivr.net/npm/simple-icons@v4/icons/hipchat.svg

@ericcornelissen
Copy link
Contributor

Considering the repo is archived and our icon is outdated, I think it should just be removed.

I'm unfamiliar with the brand, but it could just be that they moved to closed source.

This raiaes a good question: is Simple Icons a library of only currently extant icons? Just because a brand doesn't exist anymore, does that means that the brand is no longer relevant in any way for users?

While it's fine to have that discussion, as of this Pull Request this is an established process. Approximately every 6 months there's a major release that removes SVGs of brands that no longer exist as well as SVGs for brands that are not popular enough anymore. If anyone wants to change that, it's best to have a discussion about that separate from this Pull Request. If there's consensus amongst @simple-icons/maintainers that we should discuss it prior to releasing v6 than that consensus should be reached soon as that release is currently planned for November 28, 2021.

@sachinraja
Copy link
Contributor

sachinraja commented Nov 23, 2021

If you go to the login page, it tells you that the hosted version has been discontinued and you can only self-host now. But the self-hosted version is just the https://github.com/koding/koding repo, which is archived. None of the repos in the koding org show any activity, so I think it's safe to say the brand no longer exists.

@jorgeamadosoria
Copy link
Contributor

Considering the repo is archived and our icon is outdated, I think it should just be removed.

I'm unfamiliar with the brand, but it could just be that they moved to closed source.

This raiaes a good question: is Simple Icons a library of only currently extant icons? Just because a brand doesn't exist anymore, does that means that the brand is no longer relevant in any way for users?

While it's fine to have that discussion, as of this Pull Request this is an established process. Approximately every 6 months there's a major release that removes SVGs of brands that no longer exist as well as SVGs for brands that are not popular enough anymore. If anyone wants to change that, it's best to have a discussion about that separate from this Pull Request. If there's consensus amongst @simple-icons/maintainers that we should discuss it prior to releasing v6 than that consensus should be reached soon as that release is currently planned for November 28, 2021.

this has nothing to do with the v6 release. Like I said, the icon can be removed regardless. The problem is to keep it accesible in some way.

@jorgeamadosoria
Copy link
Contributor

I'm inclined to move this removal to v7 because the Alexa Rank has not been fallen enough.

Old icons shouldn't be in the main repo, but they should be somewhere. Even if only as a svg file to be downloaded

You can download old icons using the CDN link format that @service-paradis has shared https://cdn.jsdelivr.net/npm/simple-icons@v4/icons/hipchat.svg

this is good enough as hosting, but where is the discovery part? How is any end user suppose to know that exists?
It needs a note somewhere, or a page to host discontinued icons, or at least the links to the CDN.
I think this warrants a website ticket. I'll follow it up there.

@mondeja
Copy link
Member

mondeja commented Nov 23, 2021

this is good enough as hosting, but where is the discovery part? How is any end user suppose to know that exists?
It needs a note somewhere, or a page to host discontinued icons, or at least the links to the CDN.
I think this warrants a website ticket. I'll follow it up there.

I agree. A note could be added in CDN usage section of README, deprecated section of VERSIONING.md or even in both sides. Do you want to open an PR for that @jorgeamadosoria?

@mondeja
Copy link
Member

mondeja commented Nov 23, 2021

If you go to the login page, it tells you that the hosted version has been discontinued and you can only self-host now. But the self-hosted version is just the https://github.com/koding/koding repo, which is archived. None of the repos in the koding org show any activity, so I think it's safe to say the brand no longer exists.

Given that, I'm not against to include this removal in v6 👍🏼

@jorgeamadosoria
Copy link
Contributor

this is good enough as hosting, but where is the discovery part? How is any end user suppose to know that exists?
It needs a note somewhere, or a page to host discontinued icons, or at least the links to the CDN.
I think this warrants a website ticket. I'll follow it up there.

I agree. A note could be added in CDN usage section of README, deprecated section of VERSIONING.md or even in both sides. Do you want to open an PR for that @jorgeamadosoria?

I opened a ticket on the website to add a page with the links to the website. I don't know if you think I should add a page there, or just an .md document with a list of discontinued icons in the documentation for the main repo.
I'm good with either approach. As long as the user can go somewhere visible and see the icons we removed in each release, that should be enough for them.

@ericcornelissen ericcornelissen merged commit 7b709e4 into simple-icons:develop Nov 24, 2021
@ericcornelissen ericcornelissen removed the in discussion There is an ongoing discussion that should be finished before we can continue label Nov 24, 2021
@github-actions github-actions bot removed the out of scope Issues or pull requests that are beyond the scope of the project label Nov 24, 2021
mondeja added a commit that referenced this pull request Nov 28, 2021
# New Icons

- Chromecast (#6901)
- Game & Watch (#6876)
- Lerna (#5524)
- MUI (#6730)
- QuickLook (#6874)
- Salt Project (#6897)
- The Algorithms (#6917)

# Updated Icons

- BandLab (#6887)
- Deno (#6771)

# Removed Icons

- Fedora (#6892)
- Google Cast (#6901)
- Koding (#3912)
- Material-UI (#6902)
- PJSIP (#4910)
- SaltStack (#6891)
- Skyliner (#6890)
@fbernhart fbernhart deleted the Updated_Koding branch December 26, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Issues or pull requests that include a breaking change and scheduled for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Koding icon
8 participants