Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum NodeJS version requirement to package.json #3979

Merged
merged 2 commits into from Nov 21, 2020

Conversation

mondeja
Copy link
Member

@mondeja mondeja commented Nov 20, 2020

Issue: #3959

Minimum version of NodeJS required to install simple-icons will be 0.12.18 after this pull.

@mondeja mondeja added the meta Issues or pull requests regarding the project or repository itself label Nov 20, 2020
Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is okay with me, if it turns out to be incorrect I guess we will find out soon enough 🙃

Nevertheless, here are two language features we use that might potentially be missing from 0.12.18, though i wasn't able to verify this:

If you can verify this @mondeja that would be great. Otherwise, you can merge this after fixing the requested change and we will find out later whether or not these are (or something else is) a problem.

package.json Outdated Show resolved Hide resolved
@ericcornelissen ericcornelissen added changes requested package Pull requests or issues that affect the NPM package and removed meta Issues or pull requests regarding the project or repository itself labels Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package Pull requests or issues that affect the NPM package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants